From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] usb: io_edgeport: eliminate get_string()
Date: Tue, 26 Jan 2010 09:21:12 +0000 [thread overview]
Message-ID: <20100126092112.GF3061@bicker> (raw)
In-Reply-To: <20100125115333.GD3061@bicker>
On Tue, Jan 26, 2010 at 07:50:22AM +0100, Oliver Neukum wrote:
> Am Dienstag, 26. Januar 2010 05:27:31 schrieb Greg KH:
> > > Good point. But if that is considered critical enough then Dan's
> > > original patch should go to stable instead of this one. And so should
> > > the other 10+ DMA-to-stack patches in Greg's tree?
> >
> > Given the age of this bug (1999) and the fact that the devices are no
> > longer made, I don't think this is -stable worthy.
>
> That's an odd form of reasoning. As the patch touches just this driver
> it makes no difference if you don't have the hardware. If you have
> the hardware on an architecture where it matters, this is no longer
> true.
>
> Regards
> Oliver
There are 89 files that do dma on the stack in the -rc5 kernel. No one
ever complains about it, so it can't be that serious.
regards,
dan carpenter
next prev parent reply other threads:[~2010-01-26 9:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 11:53 [patch] usb: io_edgeport: eliminate get_string() Dan Carpenter
2010-01-25 16:57 ` Johan Hovold
2010-01-25 20:40 ` Greg KH
2010-01-25 20:41 ` Greg KH
2010-01-25 20:41 ` Greg KH
2010-01-25 20:54 ` Johan Hovold
2010-01-25 21:47 ` Oliver Neukum
2010-01-25 22:13 ` Johan Hovold
2010-01-26 4:27 ` Greg KH
2010-01-26 6:50 ` Oliver Neukum
2010-01-26 9:15 ` Dan Carpenter
2010-01-26 9:21 ` Dan Carpenter [this message]
2010-01-26 9:46 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100126092112.GF3061@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.