All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Wu Zhangjin <wuzhangjin@gmail.com>
Cc: Alexander Clouter <alex@digriz.org.uk>, linux-mips@linux-mips.org
Subject: Re: [PATCHv2] MIPS: fix vmlinuz build for 32bit-only math shells
Date: Tue, 26 Jan 2010 13:44:04 +0100	[thread overview]
Message-ID: <20100126124404.GF30098@linux-mips.org> (raw)
In-Reply-To: <1264247776.14811.8.camel@falcon>

On Sat, Jan 23, 2010 at 07:56:16PM +0800, Wu Zhangjin wrote:
> From: Wu Zhangjin <wuzhangjin@gmail.com>
> Date:   Sat, 23 Jan 2010 19:56:16 +0800
> To: Ralf Baechle <ralf@linux-mips.org>
> Cc: Alexander Clouter <alex@digriz.org.uk>, linux-mips@linux-mips.org
> Subject: Re: [PATCHv2] MIPS: fix vmlinuz build for 32bit-only math shells
> Content-Type: text/plain; charset="UTF-8"
> 
> On Fri, 2010-01-22 at 15:52 +0100, Ralf Baechle wrote:
> > On Wed, Jan 20, 2010 at 08:50:07PM +0000, Alexander Clouter wrote:
> > 
> > > Counter to the documentation for the dash shell, it seems that on my
> > > x86_64 filth under Debian only does 32bit math.  As I have configured my
> > 
> > POSIX apparently specifies at least "long" type arithmetic for shells, so
> > if your dash indeed is a 64-bit binary it's in violation of POSIX.  What
> > does
> > 
> >   file $(which $SHELL)
> > 
> > say?
> > 
> > The dash binary on my Fedora 12 i386 seems to perform 64-bit arithmetic.
> > 
> 
> Hi, Ralf
> 
> on my yeeloong laptop, with dash(0.5.5.1-3) in o32 ABI, it also can only
> execute 32-bit numbers, but on my thinkpad SL400(i686, dash version is
> 0.5.5.1-2), it works well with 64-bit arithmetic.
> 
> So, it means dash not always works normally, perhaps there is a bug
> there, or the bug only exists on MIPS machines?

Well, I was wondering if the dash being used by Alexander is simply
defect.  However in the end that doesn't matter; we try to restrict
the build environment to just a standard POSIX environment - or at least
as close as possible and that means we can only expect $((<expression))
to perform 32-bit arithmetic.

I've applied the patch for now but this is ugly.  I was even considering
if a small host C program that does the math is the lesser evil.

That said, applied.  Thanks folks!

  Ralf

      reply	other threads:[~2010-01-26 12:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-20 20:50 [PATCHv2] MIPS: fix vmlinuz build for 32bit-only math shells Alexander Clouter
2010-01-21  5:23 ` Wu Zhangjin
2010-01-22 14:52 ` Ralf Baechle
2010-01-22 21:39   ` Alexander Clouter
2010-01-23 11:56   ` Wu Zhangjin
2010-01-26 12:44     ` Ralf Baechle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100126124404.GF30098@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=alex@digriz.org.uk \
    --cc=linux-mips@linux-mips.org \
    --cc=wuzhangjin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.