diff for duplicates of <20100126130057.GS15759@rakim.wolfsonmicro.main> diff --git a/a/1.txt b/N1/1.txt index e03338d..d30f809 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,9 +3,9 @@ On Tue, Jan 26, 2010 at 09:11:55PM +0900, jassi brar wrote: > > That's not addressing the problem, though - the big issue is not > > bringing up the AC97 link, it's the fact that you're doing an -> > uncontrolled cold reset. If we hit this code path it'll revert the +> > uncontrolled cold reset. ?If we hit this code path it'll revert the > > device registers to default which will upset the drivers for the CODEC -> > rather badly. There should be no possibility of that happening, if it +> > rather badly. ?There should be no possibility of that happening, if it > > is happening it's something that callers really should know about. > It should never be reached after the link is up and running. Only if something @@ -18,9 +18,9 @@ Sounds like the code should be changed to log and return an error if that case is hit? > -> >> >> + ac_glbctrl = S3C_AC97_GLBCTRL_ACLINKON; -> >> >> + writel(ac_glbctrl, s3c_ac97.regs + S3C_AC97_GLBCTRL); -> >> >> + msleep(1); +> >> >> + ? ? ac_glbctrl = S3C_AC97_GLBCTRL_ACLINKON; +> >> >> + ? ? writel(ac_glbctrl, s3c_ac97.regs + S3C_AC97_GLBCTRL); +> >> >> + ? ? msleep(1); ... diff --git a/a/content_digest b/N1/content_digest index 016f486..66372d7 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,16 +4,10 @@ "ref\01b68c6791001260317k44893521vc0310ea35bac8ee1@mail.gmail.com\0" "ref\020100126115258.GM15759@rakim.wolfsonmicro.main\0" "ref\01b68c6791001260411u2b39d8actf35a0f3541fda92d@mail.gmail.com\0" - "From\0Mark Brown <broonie@opensource.wolfsonmicro.com>\0" - "Subject\0Re: [PATCH 2/3] ASoC: AC97: S3C: Add controller driver\0" + "From\0broonie@opensource.wolfsonmicro.com (Mark Brown)\0" + "Subject\0[PATCH 2/3] ASoC: AC97: S3C: Add controller driver\0" "Date\0Tue, 26 Jan 2010 13:00:57 +0000\0" - "To\0jassi brar <jassisinghbrar@gmail.com>\0" - "Cc\0alsa-devel@alsa-project.org" - linux-arm-kernel@lists.infradead.org - ben-linux@fluff.org - lrg@slimlogic.co.uk - linux-samsung-soc@vger.kernel.org - " Jassi Brar <jassi.brar@samsung.com>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Tue, Jan 26, 2010 at 09:11:55PM +0900, jassi brar wrote:\n" @@ -21,9 +15,9 @@ "\n" "> > That's not addressing the problem, though - the big issue is not\n" "> > bringing up the AC97 link, it's the fact that you're doing an\n" - "> > uncontrolled cold reset. \302\240If we hit this code path it'll revert the\n" + "> > uncontrolled cold reset. ?If we hit this code path it'll revert the\n" "> > device registers to default which will upset the drivers for the CODEC\n" - "> > rather badly. \302\240There should be no possibility of that happening, if it\n" + "> > rather badly. ?There should be no possibility of that happening, if it\n" "> > is happening it's something that callers really should know about.\n" "\n" "> It should never be reached after the link is up and running. Only if something\n" @@ -36,9 +30,9 @@ "that case is hit?\n" "\n" "> \n" - "> >> >> + \302\240 \302\240 ac_glbctrl = S3C_AC97_GLBCTRL_ACLINKON;\n" - "> >> >> + \302\240 \302\240 writel(ac_glbctrl, s3c_ac97.regs + S3C_AC97_GLBCTRL);\n" - "> >> >> + \302\240 \302\240 msleep(1);\n" + "> >> >> + ? ? ac_glbctrl = S3C_AC97_GLBCTRL_ACLINKON;\n" + "> >> >> + ? ? writel(ac_glbctrl, s3c_ac97.regs + S3C_AC97_GLBCTRL);\n" + "> >> >> + ? ? msleep(1);\n" "\n" "...\n" "\n" @@ -58,4 +52,4 @@ "controller and the CODECs on the bus. It's not particularly pretty from\n" a software point of view at the minute. -95023b949c54f2e4b9647b892690e95bf8ab472a72b23e66f7234f9ef181fd0a +731b80a0caed4f6a674463b15b714a3af04a02d4853ea93d34449c887a6ccfc9
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.