From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NZogD-0003XD-3D for mharc-grub-devel@gnu.org; Tue, 26 Jan 2010 11:54:17 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NZogB-0003Vd-EG for grub-devel@gnu.org; Tue, 26 Jan 2010 11:54:15 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NZog6-0003Q1-6R for grub-devel@gnu.org; Tue, 26 Jan 2010 11:54:14 -0500 Received: from [199.232.76.173] (port=32971 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NZog6-0003Pk-0C for grub-devel@gnu.org; Tue, 26 Jan 2010 11:54:10 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:39258 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NZog5-0005aF-El for grub-devel@gnu.org; Tue, 26 Jan 2010 11:54:09 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1NZog0-0005RR-Cq for grub-devel@gnu.org; Tue, 26 Jan 2010 17:54:06 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1NZofw-0007xF-JJ for grub-devel@gnu.org; Tue, 26 Jan 2010 17:54:00 +0100 Date: Tue, 26 Jan 2010 17:54:00 +0100 From: Robert Millan To: The development of GNU GRUB Message-ID: <20100126165400.GA30529@thorin> References: <20100125080620.GA14131@thorin> <4B5DFB57.5020703@t-online.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B5DFB57.5020703@t-online.de> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: On gratuitous modularization X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jan 2010 16:54:15 -0000 On Mon, Jan 25, 2010 at 09:13:11PM +0100, Christian Franke wrote: > > The module ata_pthru.mod exists only to keep ata.mod small, see: > http://lists.gnu.org/archive/html/grub-devel/2009-02/msg00091.html I see. Thanks for pointing this out. > Keeping the ata.mod specific pass-through function separate from > hdparm.mod was intentional. Merging this function into hdparm.mod would > only make sense if ata.mod will the only ATA access module with > pass-through functionality in the future. Note that linking ata_pthru.c into hdparm.mod doesn't prevent this code from being linked into other modules if/when the need arises. But right now, it's only used by hdparm. I see little justification in having a separate module in this situation. I'm inclined to merge it. > BTW: I agree that using a global function pointer > 'grub_disk_ata_pass_through' is a hack. A cleaner design would be > possible with a grub_disk_dev.ioctl(.) call. The problem I see with 'grub_disk_ata_pass_through' is that it shouldn't be in kernel. The interface itself is less relevant IMO. -- Robert Millan "Be the change you want to see in the world" -- Gandhi