From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NZotz-000268-4Z for mharc-grub-devel@gnu.org; Tue, 26 Jan 2010 12:08:31 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NZotx-00023Y-8z for grub-devel@gnu.org; Tue, 26 Jan 2010 12:08:29 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NZots-0001wV-DW for grub-devel@gnu.org; Tue, 26 Jan 2010 12:08:28 -0500 Received: from [199.232.76.173] (port=50461 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NZots-0001w5-7J for grub-devel@gnu.org; Tue, 26 Jan 2010 12:08:24 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:37893 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NZotr-00023h-Rt for grub-devel@gnu.org; Tue, 26 Jan 2010 12:08:24 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1NZotp-0005Sw-Gt for grub-devel@gnu.org; Tue, 26 Jan 2010 18:08:22 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1NZotm-00082A-6I for grub-devel@gnu.org; Tue, 26 Jan 2010 18:08:18 +0100 Date: Tue, 26 Jan 2010 18:08:18 +0100 From: Robert Millan To: grub-devel@gnu.org Message-ID: <20100126170818.GA30854@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: PXE directory listing incorrectly reported as "success" X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jan 2010 17:08:29 -0000 Hi, It appears that directory listing isn't supported by TFTP protocol (so says our wiki). Our pxe.c implements grub_pxefs_dir() as a dummy stub that returns GRUB_ERR_NONE. This is obviously wrong, as it prevents the user from noticing that there was a problem, and silently reports an "empty" directory. Instead, it should call grub_error (). Unfortunately, kern/fs.c relies on grub_pxefs_dir() returning GRUB_ERR_NONE in order to consider probing to be succesful. If pxe returned an error, it wouldn't be considered a valid filesystem by the kernel. So I'm wondering, what would be a good solution to this? We could add a proper probe() function and switch all filesystems to it, but only for the benefit of pxe it seems a bit overkill. Does someone have a better idea? -- Robert Millan "Be the change you want to see in the world" -- Gandhi