From: Andrew Morton <akpm@linux-foundation.org>
To: Thiago Farina <tfransosi@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Roland McGrath <roland@redhat.com>, WANG Cong <amwang@redhat.com>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs/binfmt_elf.c: fix a do-while statement.
Date: Tue, 26 Jan 2010 18:07:52 -0800 [thread overview]
Message-ID: <20100126180752.951509b5.akpm@linux-foundation.org> (raw)
In-Reply-To: <a4c8a6d01001261744n37e3472em8e772d9ecf368adf@mail.gmail.com>
On Tue, 26 Jan 2010 23:44:29 -0200 Thiago Farina <tfransosi@gmail.com> wrote:
> > It is somewhat unconventional coding style and it'd be good if
> > checkpatch were to warn so that we don't _add_ such things to the tree.
> >
> > But IMO it's such a minor thing that once it _is_ in the tree, it's not
> > really worth the patch noise to go and fix it up.
>
> Yeah, much noise for a small thing. I will not fix more warnings like
> this in future.
I'd be OK with fixing things like this as part of a larger
"fs/binfmt_elf.c: coding-style fixes" or "fs/*elf.c: ...", etc. One
big hit. It's the little dribble of one-line fixes which I'd prefer to
avoid.
prev parent reply other threads:[~2010-01-27 2:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 4:03 [PATCH] fs/binfmt_elf.c: fix a do-while statement Thiago Farina
2010-01-21 6:22 ` Cong Wang
2010-01-27 0:06 ` Andrew Morton
2010-01-27 1:44 ` Thiago Farina
2010-01-27 2:07 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100126180752.951509b5.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=amwang@redhat.com \
--cc=hugh.dickins@tiscali.co.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=tfransosi@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.