From: Stephen Hemminger <shemminger@vyatta.com>
To: Mike McCormack <mikem@ring3k.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] sky2: Remove failure cases for sky2_rx_start
Date: Wed, 27 Jan 2010 09:10:24 -0800 [thread overview]
Message-ID: <20100127091024.2ac97d81@nehalam> (raw)
In-Reply-To: <4B605652.6020400@ring3k.org>
On Thu, 28 Jan 2010 00:05:54 +0900
Mike McCormack <mikem@ring3k.org> wrote:
> sky2_rx_start() can no longer fail, so remove redundant code pathes.
>
> Signed-off-by: Mike McCormack <mikem@ring3k.org>
This can't work right if MTU is increased. The buffers need to be reallocated
in change_mtu(); and yes it could fail when getting the new buffers.
--
next prev parent reply other threads:[~2010-01-27 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 15:05 [PATCH 3/3] sky2: Remove failure cases for sky2_rx_start Mike McCormack
2010-01-27 17:10 ` Stephen Hemminger [this message]
2010-01-27 22:30 ` Mike McCormack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100127091024.2ac97d81@nehalam \
--to=shemminger@vyatta.com \
--cc=mikem@ring3k.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.