From: Ingo Molnar <mingo@elte.hu>
To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
brgerst@gmail.com, tglx@linutronix.de
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/asm] x86-64: Use normal ptregs stub for execve
Date: Wed, 27 Jan 2010 14:07:16 +0100 [thread overview]
Message-ID: <20100127130716.GA26908@elte.hu> (raw)
In-Reply-To: <tip-f19a25c872b20ae4357f72687cf3e7b0da220ee2@git.kernel.org>
* tip-bot for Brian Gerst <brgerst@gmail.com> wrote:
> Commit-ID: f19a25c872b20ae4357f72687cf3e7b0da220ee2
> Gitweb: http://git.kernel.org/tip/f19a25c872b20ae4357f72687cf3e7b0da220ee2
> Author: Brian Gerst <brgerst@gmail.com>
> AuthorDate: Mon, 25 Jan 2010 10:47:33 -0500
> Committer: H. Peter Anvin <hpa@zytor.com>
> CommitDate: Tue, 26 Jan 2010 23:38:14 -0800
>
> x86-64: Use normal ptregs stub for execve
>
> Execve historically passed regs by value, so it had a seperate stub.
> This is no longer true, so change it to use a normal PTREGSCALL stub.
>
> Signed-off-by: Brian Gerst <brgerst@gmail.com>
> LKML-Reference: <1264434453-2204-1-git-send-email-brgerst@gmail.com>
> Signed-off-by: H. Peter Anvin <hpa@zytor.com>
> ---
> arch/x86/kernel/entry_64.S | 17 +----------------
> 1 files changed, 1 insertions(+), 16 deletions(-)
FYI, -tip testing found that this commit breaks the grub binary on 64-bit,
simply running /sbin/grub causes it to segfault:
[ 3145.999766] grub[6706] general protection ip:805c481 sp:ff95629c error:0 in
grub[8048000+8c000]
i've excluded this commit for now.
Ingo
next prev parent reply other threads:[~2010-01-27 13:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 15:47 [PATCH] x86-64: Use normal ptregs stub for execve Brian Gerst
2010-01-27 8:39 ` [tip:x86/asm] " tip-bot for Brian Gerst
2010-01-27 13:07 ` Ingo Molnar [this message]
2010-01-27 15:21 ` Brian Gerst
2010-01-27 16:28 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100127130716.GA26908@elte.hu \
--to=mingo@elte.hu \
--cc=brgerst@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.