All of lore.kernel.org
 help / color / mirror / Atom feed
From: ben-linux@fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: S3C: Configuration override for UART names
Date: Wed, 27 Jan 2010 14:59:59 +0000	[thread overview]
Message-ID: <20100127145959.GK10014@trinity.fluff.org> (raw)
In-Reply-To: <1264601924-18480-2-git-send-email-buserror@gmail.com>

On Wed, Jan 27, 2010 at 02:18:43PM +0000, Michel Pollet wrote:
> S3C UART devices  are named s3c2410_serialX and it is
> inconsistent with the kernel at boot time (console=ttySACx)
> This patch allows the config file to override this and
> use the standard name instead.

Is this fixing an actual problem? if so what problem?
 
> Signed-off-by: Michel Pollet <buserror@gmail.com>
> ---
>  drivers/serial/samsung.c |    9 ++++++++-
>  1 files changed, 8 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c
> index 52e3df1..e3dd135 100644
> --- a/drivers/serial/samsung.c
> +++ b/drivers/serial/samsung.c
> @@ -55,7 +55,14 @@
>  
>  /* UART name and device definitions */
>  
> +#ifdef CONFIG_S3C_STD_UART_NAMES
> +/* All other SoC use this naming sheme, 
> +   including the kernel earlier at boot time */
>  #define S3C24XX_SERIAL_NAME	"ttySAC"
> +#else
> +/* Legacy option */
> +#define S3C24XX_SERIAL_NAME	"s3c2410_serial"
> +#endif
>  #define S3C24XX_SERIAL_MAJOR	204
>  #define S3C24XX_SERIAL_MINOR	64
>  
> @@ -878,7 +885,7 @@ static struct uart_ops s3c24xx_serial_ops = {
>  
>  static struct uart_driver s3c24xx_uart_drv = {
>  	.owner		= THIS_MODULE,
> -	.dev_name	= "s3c2410_serial",
> +	.dev_name	= S3C24XX_SERIAL_NAME,
>  	.nr		= CONFIG_SERIAL_SAMSUNG_UARTS,
>  	.cons		= S3C24XX_SERIAL_CONSOLE,
>  	.driver_name	= S3C24XX_SERIAL_NAME,
> -- 
> 1.6.6
> 

-- 
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

  parent reply	other threads:[~2010-01-27 14:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-27 14:18 [PATCH 1/3] ARM: S3C2412: SoC has the fractional baud rate register Michel Pollet
2010-01-27 14:18 ` [PATCH 2/3] ARM: S3C: Configuration override for UART names Michel Pollet
2010-01-27 14:18   ` [PATCH 3/3] ARM: S3C: Kconfig option related to UART dev names Michel Pollet
2010-01-27 14:59     ` Ben Dooks
2010-01-27 14:59   ` Ben Dooks [this message]
2010-01-27 15:08     ` [PATCH 2/3] ARM: S3C: Configuration override for UART names M P
2010-01-27 14:58 ` [PATCH 1/3] ARM: S3C2412: SoC has the fractional baud rate register Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100127145959.GK10014@trinity.fluff.org \
    --to=ben-linux@fluff.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.