From: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: git@vger.kernel.org, Tor Arvid Lund <torarvid@gmail.com>
Subject: Re: [PATCH v2] Fix remote.<remote>.vcs
Date: Wed, 27 Jan 2010 20:59:27 +0200 [thread overview]
Message-ID: <20100127185927.GA22630@Knoppix> (raw)
In-Reply-To: <alpine.LNX.2.00.1001271335140.14365@iabervon.org>
On Wed, Jan 27, 2010 at 01:39:00PM -0500, Daniel Barkalow wrote:
> On Wed, 27 Jan 2010, Ilari Liusvaara wrote:
> >
> > if (!remote)
> > die("No remote provided to transport_get()");
> >
> > ret->remote = remote;
> > + helper = remote->foreign_vcs;
>
> Needs to be "helper = remote ? remote->foreign_vcs : NULL", for the same
> reason that the test below had been "remote && remote->foreign_vcs".
Few lines above that:
if (!remote)
die("No remote provided to transport_get()");
-Ilari
next prev parent reply other threads:[~2010-01-27 18:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 17:53 [PATCH v2] Fix remote.<remote>.vcs Ilari Liusvaara
2010-01-27 18:09 ` Sverre Rabbelier
2010-01-27 18:39 ` Daniel Barkalow
2010-01-27 18:59 ` Ilari Liusvaara [this message]
2010-01-27 20:22 ` Junio C Hamano
2010-01-27 23:54 ` Daniel Barkalow
2010-01-27 19:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100127185927.GA22630@Knoppix \
--to=ilari.liusvaara@elisanet.fi \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=torarvid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.