All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
Cc: "containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
	<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Subject: Re: almost ckpt-v19-rc3
Date: Wed, 27 Jan 2010 18:48:06 -0600	[thread overview]
Message-ID: <20100128004806.GA4618@us.ibm.com> (raw)
In-Reply-To: <4B60B1E9.4060005-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>

Quoting Oren Laadan (orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org):
> Hi,
> 
> I pushed ckpt-v19-rc2.9 which has all patches (*) inside and folded
> to a clean set. It passes basic tests here.
> 
> (*) except the recent fix to s390 restart-blocks
> 
> Next step is to rebase it to a recent kernel and push again as v19-rc3.
> 
> Please give it a try, see if I missed anything.

Doh, actually, there is still a problem with IA32 tasks on x86-64:
if COMPAT_VDSO=y then the do_munmap() in destroy_mm() fails bc
vma->end > TASK_SIZE (vma->start == TASK_SIZE).  The reason this
doesn't cause a problem on x86-32, actually, is only bc the vdso
page doesn't seem to be in the list of vma's at all!  At least a
printk in destroy_mm() (a few days ago) never showed it running
across the vdso page.

So, perhaps the way to simultaneously solve both this and the unmaps
of 64-bit mappings in /bin/restart_64 after it has switched to
TIF_IA32 is to move destroy_mm() to a proper helper in mm/mmap.c,
and have it tell do_munmap() to avoid the TASK_SIZE check.

-serge

      parent reply	other threads:[~2010-01-28  0:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-27 21:36 almost ckpt-v19-rc3 Oren Laadan
     [not found] ` <4B60B1E9.4060005-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2010-01-27 22:57   ` Serge E. Hallyn
2010-01-28  0:48   ` Serge E. Hallyn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100128004806.GA4618@us.ibm.com \
    --to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.