From: Christoph Hellwig <hch@lst.de>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Christoph Hellwig <hch@lst.de>,
jgarzik@pobox.com, linux-ide@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH] libata: fix ata_id_logical_per_physical_sectors
Date: Thu, 28 Jan 2010 11:59:27 +0100 [thread overview]
Message-ID: <20100128105927.GA26711@lst.de> (raw)
In-Reply-To: <4B616D55.6080802@ru.mvista.com>
On Thu, Jan 28, 2010 at 01:56:21PM +0300, Sergei Shtylyov wrote:
> > static inline u8 ata_id_logical_per_physical_sectors(const u16 *id)
> > {
> >- return id[ATA_ID_SECTOR_SIZE] & 0xf;
> >+ return 1 << (id[ATA_ID_SECTOR_SIZE] & 0xf);
> >
>
> Will this still fit into u8?
Right now the only value we get in practice is 8 for 4k sector drivers
which still fits fine into an u8. But it might indeed be safer to use a
large value.
next prev parent reply other threads:[~2010-01-28 11:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 10:42 [PATCH] libata: fix ata_id_logical_per_physical_sectors Christoph Hellwig
2010-01-28 10:56 ` Sergei Shtylyov
2010-01-28 10:59 ` Christoph Hellwig [this message]
2010-01-28 12:30 ` [PATCH v2] " Christoph Hellwig
2010-02-03 17:37 ` Christoph Hellwig
2010-02-03 17:42 ` Jeff Garzik
2010-02-03 18:14 ` Martin K. Petersen
2010-02-03 18:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100128105927.GA26711@lst.de \
--to=hch@lst.de \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.