Re: CBQ broken in 2.6

[Jarek Poplawski <jarkao2@gmail.com>]

On 27-01-2010 13:28, Anton Ivanov wrote:
> Thanks it is indeed sch_cbq.c,
> 
> I have been going through the code in the meantime and found a place
> where cl->tparent can be modified further down in the routine in
> question. There is an invocation of cbq_set_lss() around the end of
> cbq_change_class() which can do that.
> 
> I am rebuilding the kernel for my CBQ box with a few printks at the
> moment to see if it modified there or not.
> 
> In any case here is the tell-tale symptom:
> 
> class cbq 1:16 parent 1: leaf 76: rate 5600Kbit (bounded,isolated) prio
> 2
>  Sent 162051 bytes 925 pkt (dropped 0, overlimits 0 requeues 0)
>  rate 0bit 0pps backlog 0b 0p requeues 0
>   borrowed 201 overactions 0 avgidle 78 undertime 0
> 
> That is a bounded class. Its borrowed should be always 0 no matter what.
> That is basically a broken CBQ implementation.
> 
> An elementary network test suite shows the same result - it is being
> allowed to borrow.
> 
> I am happy to send the whole config if necessary if someone wants to
> look at it.

Was this class created as bounded or changed later? Did it have any
child?

Jarek P.