Re: [Qemu-devel] Re: Stop using "which" in ./configure

["Loïc Minier" <lool@dooz.org>]

[-- Attachment #1: Type: text/plain, Size: 772 bytes --]

On Wed, Jan 27, 2010, Blue Swirl wrote:
> That must've been it. But I get this on Milax:

 I didn't know about MilaX; I had a hard time getting gcc/binutils (or
 event git) to work along with working headers or base libs such as
 zlib.h or unistd.h.  Do you have any instructions on how to get these
 working?

> config-host.mak is out-of-date, running configure
> /bin/ginstall: cannot stat `=': No such file or directory

 Ok; this was a typo in the Solaris patch (note that I was reluctant to
 touch the Solaris code in the first place); I could reproduce and also
 noticed that /bin/sh on MilaX doesn't support "if ! foo", so I replaced
 these with "if foo; then :; else ...; fi" constructs.

 Please find an attached third patch.

-- 
Loïc Minier

[-- Attachment #2: 0002-Solaris-test-for-presence-of-commands-with-has.patch --]
[-- Type: text/x-diff, Size: 1506 bytes --]

>From 6fef73a3b890ec736cdfa1ff817230c8e6d760e3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Minier?= <lool@dooz.org>
Date: Wed, 20 Jan 2010 12:35:54 +0100
Subject: [PATCH 2/2] Solaris: test for presence of commands with has()

---
 configure |   12 +++++++-----
 1 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/configure b/configure
index 6bdd2b7..42ef628 100755
--- a/configure
+++ b/configure
@@ -803,21 +803,23 @@ fi
 # Solaris specific configure tool chain decisions
 #
 if test "$solaris" = "yes" ; then
-  solinst=`path_of $install`
-  if test -z "$solinst" ; then
+  if has $install; then
+    :
+  else
     echo "Solaris install program not found. Use --install=/usr/ucb/install or"
     echo "install fileutils from www.blastwave.org using pkg-get -i fileutils"
     echo "to get ginstall which is used by default (which lives in /opt/csw/bin)"
     exit 1
   fi
-  if test "$solinst" = "/usr/sbin/install" ; then
+  if test "`path_of $install`" = "/usr/sbin/install" ; then
     echo "Error: Solaris /usr/sbin/install is not an appropriate install program."
     echo "try ginstall from the GNU fileutils available from www.blastwave.org"
     echo "using pkg-get -i fileutils, or use --install=/usr/ucb/install"
     exit 1
   fi
-  sol_ar=`path_of ar`
-  if test -z "$sol_ar" ; then
+  if has ar; then
+    :
+  else
     echo "Error: No path includes ar"
     if test -f /usr/ccs/bin/ar ; then
       echo "Add /usr/ccs/bin to your path and rerun configure"
-- 
1.6.5