From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NabSx-0007yz-5s
	for qemu-devel@nongnu.org; Thu, 28 Jan 2010 15:59:51 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NabSr-0007x1-Cf
	for qemu-devel@nongnu.org; Thu, 28 Jan 2010 15:59:49 -0500
Received: from [199.232.76.173] (port=32834 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NabSr-0007wy-8m
	for qemu-devel@nongnu.org; Thu, 28 Jan 2010 15:59:45 -0500
Received: from ozlabs.org ([203.10.76.45]:41035)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <rusty@rustcorp.com.au>) id 1NabSq-0005w4-Jb
	for qemu-devel@nongnu.org; Thu, 28 Jan 2010 15:59:45 -0500
From: Rusty Russell <rusty@rustcorp.com.au>
Date: Fri, 29 Jan 2010 07:29:37 +1030
References: <20100128124327.GA32288@lst.de>
In-Reply-To: <20100128124327.GA32288@lst.de>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201001290729.37532.rusty@rustcorp.com.au>
Subject: [Qemu-devel] Re: future of the virtio-blk serial number support
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: john cooper <john.cooper@redhat.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

On Thu, 28 Jan 2010 11:13:27 pm Christoph Hellwig wrote:
> Back iSeptember 2007 Michael made the serial number support in qemu
> optional and off by default, and in October 2009 Rusty reverted the
> Linux virtio-blk support for it.  Given that I can't find support in
> any other virtio implementation that makes the feature look essentially
> dead.
> 
> How should we proceed with adding more fields to struct virtio_blk_config?
> I would suggest removing the identity field, declaring
> VIRTIO_BLK_F_IDENTIFY officially deprecated and adding the new fields
> directly after blk_size again, maybe with a comment that these new
> features can't be advertized together with VIRTIO_BLK_F_IDENTIFY.

Yes, this is the correct approach.

Agreed,
Rusty.