From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: update hook for git to check push commit message
Date: Fri, 29 Jan 2010 10:15:38 +0100 [thread overview]
Message-ID: <20100129091538.GP17310@jama> (raw)
In-Reply-To: <20100129082137.GA26715@merkur.sol.de>
On Fri, Jan 29, 2010 at 09:21:38AM +0100, Jens Seidel wrote:
> On Thu, Jan 28, 2010 at 04:22:32PM -0700, Chris Larson wrote:
> > On Thu, Jan 28, 2010 at 3:59 PM, Tom Rini <tom_rini@mentor.com> wrote:
> > > On Thu, 2010-01-28 at 12:00 -0800, Khem Raj wrote:
> > > > Attached is a small hook for updates that are pushed into repo.
> > >
> > > Is there any way to force the commit to happen, even if the script
> > > doesn't like it? Can the script edit the commit message, even? ie if
> > > there's no git commit --ignore-prehook type option, could it see if the
> > > first line is FORCE or something, edit that out and commit? This will
> > > catch the poorly formed commit messages without being a big burden on
> > > people doing things that don't fit well into the "module: summary" model
> > > (that said, lib*-perl-native: Convert to BBCLASSEXTEND as a first line
> > > makes sense to me).
> >
> > My worry with editing a commit at push time is, the user's local repository
> > now no longer matches upstream.
>
> Right, what about two repositories, one with a hook which denies some
> commits and another one without such a hook. The second repository could be
> synced with the first via a cronjob and users are always forced to commit
> to the first repository except they know *exactly* what they are doing
> (maybe by restricting access to a few people only) and want to bypass these
> checks?
This looks like a bit overcomplicated sollution. I think that every
commit message "on edge" of commit policy can be made to go through.
ie:
fso_recipes: switch from SRCREV to SRCPV
instead of
fso recipes: switch from SRCREV to SRCPV
lib*-perl-native: Convert to BBCLASSEXTEND
could go through as long as it's splited by ' '
is almost as readable as original and easier to s/ /_/ then pusing to
different repo and waiting for cron job to sync it, hoping that nobody
else didn't commit conflicting change to right repo with right commit
message first.
Regards,
--
uin:136542059 jid:Martin.Jansa@gmail.com
Jansa Martin sip:jamasip@voip.wengo.fr
JaMa
prev parent reply other threads:[~2010-01-29 9:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 20:00 update hook for git to check push commit message Khem Raj
2010-01-28 21:52 ` Phil Blundell
2010-01-28 22:01 ` Frans Meulenbroeks
2010-01-29 0:26 ` Paul Menzel
2010-01-29 1:30 ` Khem Raj
2010-01-28 22:59 ` Tom Rini
2010-01-28 23:22 ` Chris Larson
2010-01-29 0:10 ` Tom Rini
2010-01-29 8:21 ` Jens Seidel
2010-01-29 9:15 ` Martin Jansa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100129091538.GP17310@jama \
--to=martin.jansa@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.