From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Daniel Mack <daniel@caiaq.de>
Cc: alsa-devel@alsa-project.org, Eric Miao <eric.y.miao@gmail.com>,
Philipp Zabel <philipp.zabel@gmail.com>
Subject: Re: [PATCH] ALSA: ASoC: fix PXA SSP port resume
Date: Fri, 29 Jan 2010 10:13:08 +0000 [thread overview]
Message-ID: <20100129101307.GA3201@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1264674858-27461-1-git-send-email-daniel@caiaq.de>
On Thu, Jan 28, 2010 at 06:34:18PM +0800, Daniel Mack wrote:
> Invalidate the cached hardware format on resume for PXA SSP ports.
> Otherwise hw_params() will bail out early at the next stream start,
> leaving the registers in a bogus state.
Would it not be better to write the cached state back to the hardware?
Putting an invalid value in the cache seems like asking for trouble.
next prev parent reply other threads:[~2010-01-29 10:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 10:34 [PATCH] ALSA: ASoC: fix PXA SSP port resume Daniel Mack
2010-01-29 10:13 ` Mark Brown [this message]
2010-01-29 11:08 ` Daniel Mack
2010-01-29 14:00 ` Mark Brown
2010-02-02 3:32 ` Daniel Mack
2010-02-02 10:51 ` Liam Girdwood
2010-02-02 10:45 ` Daniel Mack
2010-02-02 11:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100129101307.GA3201@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=daniel@caiaq.de \
--cc=eric.y.miao@gmail.com \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.