All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Anton Vorontsov <avorontsov@ru.mvista.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power_supply: Clean up wm97xx_battery warnings
Date: Fri, 29 Jan 2010 11:11:11 +0100	[thread overview]
Message-ID: <201001291111.11133.marek.vasut@gmail.com> (raw)
In-Reply-To: <1264625135-4075-1-git-send-email-broonie@opensource.wolfsonmicro.com>

Dne St 27. ledna 2010 21:45:35 Mark Brown napsal(a):
> Staticise work_lock (nothing outside the driver has any reason to
> see it) and specify dev when requesting the charger IRQ (since that's
> what we pass in when we free it).
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

Hi, thanks.

Acked-by: Marek Vasut <marek.vasut@gmail.com>

> ---
>  drivers/power/wm97xx_battery.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/wm97xx_battery.c
>  b/drivers/power/wm97xx_battery.c index 6ea3cb5..23eed35 100644
> --- a/drivers/power/wm97xx_battery.c
> +++ b/drivers/power/wm97xx_battery.c
> @@ -26,7 +26,7 @@
> 
>  static DEFINE_MUTEX(bat_lock);
>  static struct work_struct bat_work;
> -struct mutex work_lock;
> +static struct mutex work_lock;
>  static int bat_status = POWER_SUPPLY_STATUS_UNKNOWN;
>  static struct wm97xx_batt_info *gpdata;
>  static enum power_supply_property *prop;
> @@ -203,7 +203,7 @@ static int __devinit wm97xx_bat_probe(struct
>  platform_device *dev) goto err2;
>  		ret = request_irq(gpio_to_irq(pdata->charge_gpio),
>  				wm97xx_chrg_irq, IRQF_DISABLED,
> -				"AC Detect", 0);
> +				"AC Detect", dev);
>  		if (ret)
>  			goto err2;
>  		props++;	/* POWER_SUPPLY_PROP_STATUS */
> 

  reply	other threads:[~2010-01-29 10:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-27 20:45 [PATCH] power_supply: Clean up wm97xx_battery warnings Mark Brown
2010-01-29 10:11 ` Marek Vasut [this message]
2010-01-29 14:04   ` Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201001291111.11133.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=avorontsov@ru.mvista.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.