All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin LaHaise <bcrl@lhnet.ca>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] xfrm: avoid spinlock in get_acqseq()
Date: Fri, 29 Jan 2010 10:11:49 -0500	[thread overview]
Message-ID: <20100129151149.GD20701@kvack.org> (raw)
In-Reply-To: <1264773952.3184.22.camel@edumazet-laptop>

Hi Eric,

On Fri, Jan 29, 2010 at 03:05:52PM +0100, Eric Dumazet wrote:
> Use atomic_inc_return() in get_acqseq() to avoid taking a spinlock
> +	static atomic_t acqseq;

I think that needs to be:
	static atomic_t acqseq = ATOMIC_INIT(0);

Cheers,

	-ben

  reply	other threads:[~2010-01-29 15:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-29 14:05 [PATCH] xfrm: avoid spinlock in get_acqseq() Eric Dumazet
2010-01-29 15:11 ` Benjamin LaHaise [this message]
2010-01-29 16:00   ` Eric Dumazet
2010-01-29 17:01     ` Benjamin LaHaise
2010-02-02 23:59 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100129151149.GD20701@kvack.org \
    --to=bcrl@lhnet.ca \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.