All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Ben Dooks <ben-linux@fluff.org>
Cc: linux-samsung-soc@vger.kernel.org, pierre@ossman.eu,
	linux-mmc@vger.kernel.org
Subject: Re: [PATCH] sdhci: add adma descriptor set call
Date: Fri, 29 Jan 2010 15:20:35 -0800	[thread overview]
Message-ID: <20100129152035.e04678a7.akpm@linux-foundation.org> (raw)
In-Reply-To: <1264656597-19965-2-git-send-email-ben-linux@fluff.org>

On Thu, 28 Jan 2010 05:29:56 +0000
Ben Dooks <ben-linux@fluff.org> wrote:

> The code to write the ADMA descriptor into memory is repeated several
> times throughout sdhci_adma_table_pre, and thus should be moved into a
> common function. This will also be useful if the patch to make the write
> more efficient is accepted.
> 
> ...
>
> @@ -499,15 +496,9 @@ static int sdhci_adma_table_pre(struct sdhci_host *host,
>  		/*
>  		* Add a terminating entry.
>  		*/
> -		desc[7] = 0;
> -		desc[6] = 0;
> -		desc[5] = 0;
> -		desc[4] = 0;
> -
> -		desc[3] = 0;
> -		desc[2] = 0;
> -		desc[1] = 0x00;
> -		desc[0] = 0x03; /* nop, end, valid */
> +
> +		/* nop, end, valid */
> +		sdhci_set_adma_desc(desc, 0, 0, 0x3);
>  	}

What kernel are you patching?  Current mainline is different from the above.

  reply	other threads:[~2010-01-29 23:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-28  5:29 SDHCI ADMA clenaups Ben Dooks
2010-01-28  5:29 ` [PATCH] sdhci: add adma descriptor set call Ben Dooks
2010-01-29 23:20   ` Andrew Morton [this message]
2010-02-02  9:30     ` Ben Dooks
2010-01-28  5:29 ` [PATCH] sdhci: improve sdhci sdhci_set_adma_desc() code Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100129152035.e04678a7.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=ben-linux@fluff.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=pierre@ossman.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.