From: leochen@broadcom.com (Leo (Hao) Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch 1/1] arm: bcmring: Fix locking in dma_unmap
Date: Fri, 29 Jan 2010 12:22:32 -0800 [thread overview]
Message-ID: <20100129202232.GI8104@broadcom.com> (raw)
In-Reply-To: <20100129112739.265153293@linutronix.de>
Thanks Thomas for fixing this bug.
Acked-by: Leo Chen <leochen@broadcom.com>
On Fri, Jan 29, 2010 at 03:28:45AM -0800, Thomas Gleixner wrote:
> dma_unmap is missing a down(&memMap->lock).
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Leo Chen <leochen@broadcom.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: linux-arm-kernel at lists.infradead.org
> ---
> arch/arm/mach-bcmring/dma.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> Index: linux-2.6-tip/arch/arm/mach-bcmring/dma.c
> ===================================================================
> --- linux-2.6-tip.orig/arch/arm/mach-bcmring/dma.c
> +++ linux-2.6-tip/arch/arm/mach-bcmring/dma.c
> @@ -2225,6 +2225,8 @@ int dma_unmap(DMA_MemMap_t *memMap, /* S
> DMA_Region_t *region;
> DMA_Segment_t *segment;
>
> + down(&memMap->lock);
> +
> for (regionIdx = 0; regionIdx < memMap->numRegionsUsed; regionIdx++) {
> region = &memMap->region[regionIdx];
>
>
>
>
--
Leo Hao Chen
------------------------
Life is short, run long.
parent reply other threads:[~2010-01-29 20:22 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20100129112739.265153293@linutronix.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100129202232.GI8104@broadcom.com \
--to=leochen@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.