From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH 05/11] Move event-notifications to libcrtest/common.c Date: Fri, 29 Jan 2010 20:44:28 -0600 Message-ID: <20100130024428.GA8960@us.ibm.com> References: <20100129202842.GA25490@us.ibm.com> <20100129204228.GD26721@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20100129204228.GD26721-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Sukadev Bhattiprolu Cc: Containers List-Id: containers.vger.kernel.org Quoting Sukadev Bhattiprolu (sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org): ... > diff --git a/libcrtest/libcrtest.h b/libcrtest/libcrtest.h > index a42c178..9a0a13e 100644 > --- a/libcrtest/libcrtest.h > +++ b/libcrtest/libcrtest.h > @@ -12,6 +12,10 @@ struct record { > char data[256]; > }; > > +#ifdef __i386__ > +typedef unsigned long long u64; > +#endif > + Why did you make this __i386__ only? I need this on s390 too, but am wondering whether I'll break another arch if I just remove this ifdef? Did you see this break on x86-64 or powerpc or something? -serge