All of lore.kernel.org
 help / color / mirror / Atom feed
From: nicky726@gmail.com (Nicky726)
To: refpolicy@oss.tresys.com
Subject: [refpolicy] [PATCH 1/1] Added KDE and Konqueror policy. Made necessary changes in staff, unprivuser and unconfined, for it to work.
Date: Sat, 30 Jan 2010 20:02:16 +0100	[thread overview]
Message-ID: <201001302002.16539.Nicky726@gmail.com> (raw)
In-Reply-To: <mailman.1.1264874402.23822.refpolicy@oss.tresys.com>

Thanks for your comments, I'll provide a better patch soon. In the meantime 
just some notes and questions.
 
> > +# Temp acces for konqueror
> > +manage_dirs_pattern(konqueror_t, konqueror_tmp_t, konqueror_tmp_t)
> > +manage_lnk_files_pattern(konqueror_t, konqueror_tmp_t, konqueror_tmp_t)
> > +manage_sock_files_pattern(konqueror_t, konqueror_tmp_t, konqueror_tmp_t)
> > +manage_files_pattern(konqueror_t, konqueror_tmp_t, konqueror_tmp_t)
> 
> This does probably require the user to be able to manage it

What do you mean by this?

> > +        konqueror_role(staff_r, staff_t)
> > +')
> > +
> 
> Should probably go into userdomain (common use template), but i believe
> that for reference policy these calls are not required at all (gets
> called automatically)
> 
> > +        konqueror_role(user_r, user_t)
> > +')
> 
> Same as above
> 
> > +        konqueror_role(unconfined_r, unconfined_t)
> > +')
> > +
> 
> Not sure whether it is a good idea run let unconfined_t transition

Well I'm definitely confused about where to place these calls. Fedora has it 
somewhere, refpolicy elsewhere. Could somebody provide explanation about it?

> 
> > +HOME_DIR/\.kde/share/config/konq_history	--	gen_context(system_u:object_
> >r:konqueror_home_t,s0) +
> > +HOME_DIR/\.kde/share/config/konquerorrc		--	gen_context(system_u:object_
> >r:konqueror_home_t,s0) +
> > +HOME_DIR/\.kde/share/config/konqsidebartng.rc	--	gen_context(system_u:ob
> >ject_r:konqueror_home_t,s0) +
> > +HOME_DIR/\.kde/share/config/kuriikwsfilterrc	--	gen_context(system_u:obj
> >ect_r:konqueror_home_t,s0) +
> > +HOME_DIR/\.kde/share/apps/konqueror(/.*)?		gen_context(system_u:object_r
> >:konqueror_home_t,s0) +
> > +HOME_DIR/\.kde/share/apps/khtml(/.*)?			gen_context(system_u:object_r:ko
> >nqueror_home_t,s0)
> 
> Why not just kde_shared_home_t for everything in ~/.kde
> 

Well, I hope this policy to be just a first step in constructing policies for 
other KDE aplications, which I think should be also confined from each other, 
so that e.g. a weakness in KDE browser would not endager contacts in KDE mail 
client. 

> > +gen_tunable(konqueror_exec_bin_t, false)
> 
> This shouldnt be tunable

Hm, I made it tunable, because I didn't feel quite right to let konqueror run 
bin_t just because of some bug reporting tool. Maybe that was not good idea... 
Any special reasons why it sould not be tunable?

Thanx for your time,
Ondrej Vadinsk?

-- 
Don`t it always seem to go
That you don`t know what you`ve got
Till it`s gone.

		(Joni Mitchell)

       reply	other threads:[~2010-01-30 19:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.1.1264874402.23822.refpolicy@oss.tresys.com>
2010-01-30 19:02 ` Nicky726 [this message]
2010-01-30 20:59   ` [refpolicy] [PATCH 1/1] Added KDE and Konqueror policy. Made necessary changes in staff, unprivuser and unconfined, for it to work Dominick Grift
2010-01-30 15:02 Nicky726
2010-01-30 15:29 ` Dominick Grift

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201001302002.16539.Nicky726@gmail.com \
    --to=nicky726@gmail.com \
    --cc=refpolicy@oss.tresys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.