All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Reduce footprint of irq_stat
Date: Mon, 1 Feb 2010 16:44:19 +1100	[thread overview]
Message-ID: <20100201054419.GR2996@kryten> (raw)
In-Reply-To: <1265001704.8287.31.camel@pasglop>


Hi,

> > +static inline void ack_bad_irq(unsigned int irq)
> > +{
> > +	printk(KERN_CRIT "unexpected IRQ trap at vector %02x\n", irq);
> > +}
> 
> Looks like some unrelated gunk slipped into this patch :-)

We need that to link :) 

kernel/irq/handle.c: In function ‘handle_bad_irq’:
kernel/irq/handle.c:43: error: implicit declaration of function ‘ack_bad_irq’

It's basically a copy of the fallback handler in the asm-generic hardirq.h
I'm happy to change it print "IRQ on fire" :)

Anton

      reply	other threads:[~2010-02-01  5:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-12 10:56 [PATCH] powerpc: Reduce footprint of irq_stat Anton Blanchard
2010-01-12 10:58 ` [PATCH] powerpc: Reduce footprint of xics_ipi_struct Anton Blanchard
2010-02-01  5:18   ` Benjamin Herrenschmidt
2010-02-01  6:26     ` Anton Blanchard
2010-02-01  5:21 ` [PATCH] powerpc: Reduce footprint of irq_stat Benjamin Herrenschmidt
2010-02-01  5:44   ` Anton Blanchard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100201054419.GR2996@kryten \
    --to=anton@samba.org \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.