From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5714630639890060697==" MIME-Version: 1.0 From: Denis Kenzior Subject: Re: [PATCH 1/2] Fix: Username and Password must be set after context is created. Date: Mon, 01 Feb 2010 13:20:03 -0600 Message-ID: <201002011320.04073.denkenz@gmail.com> In-Reply-To: <1265051445.31341.54.camel@localhost.localdomain> List-Id: To: ofono@ofono.org --===============5714630639890060697== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Marcel, > > > And we might wanna check if MBM cards behave similar and ensure that > > > STE and MBM cards use a similar code flow. > > > > When testing this EIAAUW fails if there are no prior PDP context on the > > modem. Most likely this is the case with the MBM module as well, but I > > have not tested this. > = > Then we have to do that in the callback in an extra step. I don't really > like it, but seems the way to go. Please send a patch that also changes > this for MBM devices. We really wanna keep these in sync. Actually the easiest way to do this is simply queue the EIAAUW after the = CGDCONT in activate_context. If CGDCONT fails then EIAAUW won't have any = effect anyway (but will get executed nevertheless). This is better than = worrying about strduping username/password and freeing it in all possible c= ode = paths. Regards, -Denis > = > Regards > = > Marcel >=20 --===============5714630639890060697==--