From: Frans Pop <elendil@planet.nl>
To: James Bottomley <James.Bottomley@suse.de>
Cc: joe@perches.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 05/10] drivers/scsi/arcmsr: Fix continuation line formats
Date: Mon, 1 Feb 2010 19:02:31 +0100 [thread overview]
Message-ID: <201002011902.33015.elendil@planet.nl> (raw)
In-Reply-To: <1265044616.6910.15.camel@mulgrave.site>
James Bottomley wrote:
>> - printk(KERN_NOTICE "arcmsr%d: wait 'flush adapter cache' \
>> - timeout, retry count down = %d \n", acb->host->host_no, retry_count);
>
> So I might personally dislike this style
The problem here is not style, but that the whitespace of the indentation
on the second line becomes part of the output!
That makes the code defective and is why Joe posted the patch series.
Cheers,
FJP
next prev parent reply other threads:[~2010-02-01 18:02 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-31 20:02 [PATCH 00/10] treewide: Fix format strings that misuse continuations Joe Perches
2010-01-31 20:02 ` Joe Perches
2010-01-31 20:02 ` Joe Perches
2010-01-31 20:02 ` [PATCH 01/10] arch/powerpc: Fix continuation line formats Joe Perches
2010-01-31 20:02 ` Joe Perches
2010-02-01 2:16 ` Benjamin Herrenschmidt
2010-02-01 2:16 ` Benjamin Herrenschmidt
2010-02-01 18:30 ` Joe Perches
2010-02-01 18:30 ` Joe Perches
2010-02-08 3:46 ` Benjamin Herrenschmidt
2010-02-08 3:46 ` Benjamin Herrenschmidt
2010-01-31 20:02 ` [PATCH 02/10] arch/blackfin: " Joe Perches
2010-01-31 20:02 ` [PATCH 03/10] drivers/ide: " Joe Perches
2010-02-04 2:44 ` David Miller
2010-01-31 20:02 ` [PATCH 04/10] drivers/serial/bfin_5xx.c: " Joe Perches
2010-01-31 20:02 ` [PATCH 05/10] drivers/scsi/arcmsr: " Joe Perches
2010-02-01 17:16 ` James Bottomley
2010-02-01 17:30 ` Joe Perches
2010-02-01 18:02 ` Frans Pop [this message]
2010-02-02 18:20 ` Stefan Richter
2010-01-31 20:02 ` [PATCH 06/10] drivers/staging: " Joe Perches
2010-01-31 21:22 ` Gábor Stefanik
2010-01-31 20:02 ` [PATCH 07/10] drivers/net/amd8111e.c: " Joe Perches
2010-02-04 2:44 ` David Miller
2010-01-31 20:02 ` [PATCH 08/10] fs/proc/array.c: " Joe Perches
2010-01-31 20:02 ` [PATCH 09/10] mm/slab.c: " Joe Perches
2010-01-31 20:02 ` Joe Perches
2010-01-31 20:08 ` Matt Mackall
2010-01-31 20:08 ` Matt Mackall
2010-01-31 20:13 ` Joe Perches
2010-01-31 20:13 ` Joe Perches
2010-01-31 20:32 ` Frans Pop
2010-01-31 20:32 ` Frans Pop
2010-01-31 20:38 ` Joe Perches
2010-01-31 20:38 ` Joe Perches
2010-01-31 23:53 ` Frans Pop
2010-01-31 23:53 ` Frans Pop
2010-01-31 20:02 ` [PATCH 10/10] sound/soc/blackfin: " Joe Perches
2010-02-01 14:47 ` Mark Brown
2010-02-01 14:47 ` Mark Brown
2010-02-01 17:08 ` Joe Perches
2010-02-02 4:13 ` Mike Frysinger
2010-02-02 4:13 ` Mike Frysinger
2010-02-02 11:08 ` Mark Brown
2010-02-02 11:08 ` Mark Brown
2010-02-02 12:55 ` [RFC PATCH] checkpatch.pl: Add warning on non #define continuation lines Joe Perches
2010-02-02 13:49 ` John Kacur
2010-02-02 17:06 ` Mike Frysinger
2010-02-02 22:34 ` [RFC PATCH V2] " Joe Perches
2010-02-02 23:18 ` Daniel Walker
2010-02-03 15:15 ` Andy Whitcroft
[not found] ` <m2n.s.201002011906064544@fjphome.nl>
2010-02-01 19:07 ` [PATCH 05/10] drivers/scsi/arcmsr: Fix continuation line formats Frans Pop
2010-02-01 19:35 ` [RFC] Fix unnecessary spaces before newlines in logging messages Joe Perches
2010-02-01 20:10 ` Frans Pop
2010-02-01 20:34 ` [PATCH] Warn on unnecessary spaces before quoted newlines Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002011902.33015.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=James.Bottomley@suse.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.