All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: xfs@oss.sgi.com
Subject: [PATCH for-2.6.33] xfs: flush all log buffers in xlog_dealloc_log
Date: Mon, 1 Feb 2010 17:08:13 -0500	[thread overview]
Message-ID: <20100201220813.GA3519@infradead.org> (raw)

Make sure all log buffers have made it to disk before we free them.
Otherwise we might reference freed buffers or a NULL mp->m_log from
the I/O completion handlers.

This fixes kernel.org bz #15150.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reported-by: Ed Cashin <ecashin@coraid.com>
Reported-by: ghani <abdelghani@ezono.com>
Tested-by: ghani <abdelghani@ezono.com>

Index: linux-2.6/fs/xfs/xfs_log.c
===================================================================
--- linux-2.6.orig/fs/xfs/xfs_log.c	2009-11-09 22:09:08.858026060 +0100
+++ linux-2.6/fs/xfs/xfs_log.c	2009-11-09 22:13:13.958255857 +0100
@@ -1602,6 +1602,8 @@ xlog_dealloc_log(xlog_t *log)
 	xlog_in_core_t	*iclog, *next_iclog;
 	int		i;
 
+	xfs_flush_buftarg(log->l_mp->m_logdev_targp, 1);
+
 	iclog = log->l_iclog;
 	for (i=0; i<log->l_iclog_bufs; i++) {
 		sv_destroy(&iclog->ic_force_wait);

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

             reply	other threads:[~2010-02-01 22:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-01 22:08 Christoph Hellwig [this message]
2010-02-03 10:55 ` [PATCH for-2.6.33] xfs: flush all log buffers in xlog_dealloc_log Christoph Hellwig
2010-02-04  8:14   ` Dave Chinner
2010-02-04 16:10     ` Christoph Hellwig
2010-02-05  2:58       ` Dave Chinner
2010-02-05 11:35         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100201220813.GA3519@infradead.org \
    --to=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.