From: Guenter Roeck <guenter.roeck@ericsson.com>
To: David Daney <ddaney@caviumnetworks.com>
Cc: "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
"Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH v3] Virtual memory size detection for 64 bit MIPS CPUs
Date: Mon, 1 Feb 2010 16:10:26 -0800 [thread overview]
Message-ID: <20100202001026.GA6883@ericsson.com> (raw)
In-Reply-To: <4B676755.10600@caviumnetworks.com>
On Mon, Feb 01, 2010 at 06:44:21PM -0500, David Daney wrote:
> Guenter Roeck wrote:
> > Linux kernel 2.6.32 and later allocates memory from the top of virtual memory
> > space.
> >
> > This patch implements virtual memory size detection for 64 bit MIPS CPUs
> > to avoid resulting crashes.
> >
> > Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> [...]
> >
> > +static inline void cpu_set_vmbits(struct cpuinfo_mips *c)
> > +{
> > + if (cpu_has_64bits) {
> > + write_c0_entryhi(0xfffffffffffff000ULL);
>
> macro indicated that we need to avoid hazards here on R4000.
>
> Perhaps adding:
>
> back_to_back_c0_hazard();
>
Compiler already added a nop, so I thought it wasn't necessary.
Doesn't hurt either, so I'll put it in.
Guenter
next prev parent reply other threads:[~2010-02-02 0:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 22:51 [PATCH v3] Virtual memory size detection for 64 bit MIPS CPUs Guenter Roeck
2010-02-01 23:44 ` David Daney
2010-02-02 0:10 ` Guenter Roeck [this message]
2010-02-02 11:42 ` Ralf Baechle
2010-02-02 15:24 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100202001026.GA6883@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=ddaney@caviumnetworks.com \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.