From: Andrew Morton <akpm@linux-foundation.org>
To: David Rientjes <rientjes@google.com>
Cc: Andreas Mohr <andi@lisas.de>,
Nick Bowler <nbowler@elliptictech.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Improve usability in case of init binary failure
Date: Tue, 2 Feb 2010 09:20:41 -0800 [thread overview]
Message-ID: <20100202092041.674f3ff0.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1002012308480.22003@chino.kir.corp.google.com>
On Mon, 1 Feb 2010 23:10:51 -0800 (PST) David Rientjes <rientjes@google.com> wrote:
> On Sun, 27 Dec 2009, Andreas Mohr wrote:
>
> > Well, took quite a while longer, partly due to broken Broadcom USB host
> > (OpenWrt fix to be submitted) and non-working USB-audio on nicer platforms.
> >
> > Took most of the comments into account (thanks!), improved some wording.
> >
> > Patch against current git, compile- and runtime-tested,
> > checkpatch.pl'd (with a single nice hierarchy warning resulting from mixing
> > git diff output and manual /dev/null diffing).
> >
> > Thanks!
> >
>
> It looks like this patch got mangled when added to mmotm-2010-02-01-16-25
> in init-mainc-improve-usability-in-case-of-init-binary-failure.patch since
> it added init.txt to the root directory instead of Documentation,
ah, thanks.
> even though the patch below is correct.
Nope, the patch was wrong:
> > --- a/init/main.c
> > +++ b/init/main.c
> ...
> > --- /dev/null 2009-12-27 16:25:29.521258205 +0100
> > +++ Documentation/init.txt 2009-12-27 15:47:46.000000000 +0100
Should've been a/Documentation/init.txt
next prev parent reply other threads:[~2010-02-02 17:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-16 19:40 [PATCH] FIX IT Andreas Mohr
2009-11-16 20:35 ` Nick Bowler
2009-11-17 20:40 ` Andreas Mohr
2009-12-27 15:03 ` [PATCH] Improve usability in case of init binary failure Andreas Mohr
2010-02-02 7:10 ` David Rientjes
2010-02-02 17:20 ` Andrew Morton [this message]
2010-02-02 17:48 ` Andreas Mohr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100202092041.674f3ff0.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andi@lisas.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nbowler@elliptictech.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.