All of lore.kernel.org
 help / color / mirror / Atom feed
From: akpm@linux-foundation.org
To: dwmw2@infradead.org
Cc: hsweeten@visionengravers.com, akpm@linux-foundation.org,
	linux-mtd@lists.infradead.org, peterhuewe@gmx.de,
	u.kleine-koenig@pengutronix.de
Subject: [patch for 2.6.33? 1/1] mtd/nand: fix build failure caused by typo
Date: Tue, 02 Feb 2010 14:12:02 -0800	[thread overview]
Message-ID: <201002022212.o12MC2HT017477@imap1.linux-foundation.org> (raw)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]

From: Peter Huewe <peterhuewe@gmx.de>

Fix a build failure introduced by the patch

    mtd: orion_nand.c: add error handling and use resource_size()

The patch assigns something to a undeclared variable 'err', whereas the
rest of the code uses 'ret' for this task.

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/mtd/nand/orion_nand.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/mtd/nand/orion_nand.c~mtd-nand-fix-build-failure-caused-by-typo drivers/mtd/nand/orion_nand.c
--- a/drivers/mtd/nand/orion_nand.c~mtd-nand-fix-build-failure-caused-by-typo
+++ a/drivers/mtd/nand/orion_nand.c
@@ -92,7 +92,7 @@ static int __init orion_nand_probe(struc
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	if (!res) {
-		err = -ENODEV;
+		ret = -ENODEV;
 		goto no_res;
 	}
 
_

             reply	other threads:[~2010-02-02 22:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-02 22:12 akpm [this message]
2010-02-03  8:07 ` [patch for 2.6.33? 1/1] mtd/nand: fix build failure caused by typo Uwe Kleine-König
2010-02-10 18:15   ` David Woodhouse
2010-02-10 19:22     ` Artem Bityutskiy
2010-02-09 12:13 ` Artem Bityutskiy
2010-02-09 17:00   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201002022212.o12MC2HT017477@imap1.linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=dwmw2@infradead.org \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=peterhuewe@gmx.de \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.