diff for duplicates of <20100203034322.GZ22747@atomide.com> diff --git a/a/2.hdr b/a/2.hdr deleted file mode 100644 index d3b4eec..0000000 --- a/a/2.hdr +++ /dev/null @@ -1,2 +0,0 @@ -Content-Type: text/plain; charset=us-ascii -Content-Disposition: inline; filename=fix-8250-timeout diff --git a/a/2.txt b/a/2.txt deleted file mode 100644 index dcaef51..0000000 --- a/a/2.txt +++ /dev/null @@ -1,51 +0,0 @@ ->From ff7ce25ec59223bf987ad209c1eb183031811c07 Mon Sep 17 00:00:00 2001 -From: Tony Lindgren <tony@atomide.com> -Date: Mon, 1 Feb 2010 12:34:31 -0800 -Subject: [PATCH] omap: Disable serial port autoidle by default - -Currently the omap serial clocks are autoidled after 5 seconds. -However, this causes lost characters on the serial ports. As this -is considered non-standard behaviour for Linux, disable the timeout. - -Note that this will also cause blocking of any deeper omap sleep -states. - -To enable the autoidling of the serial ports, do something like -this for each serial port: - -# echo 5 > /sys/devices/platform/serial8250.0/sleep_timeout -# echo 5 > /sys/devices/platform/serial8250.1/sleep_timeout -... - -Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com> -Signed-off-by: Tony Lindgren <tony@atomide.com> - -diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c -index 8c964be..e10a02d 100644 ---- a/arch/arm/mach-omap2/serial.c -+++ b/arch/arm/mach-omap2/serial.c -@@ -36,7 +36,13 @@ - #define UART_OMAP_NO_EMPTY_FIFO_READ_IP_REV 0x52 - #define UART_OMAP_WER 0x17 /* Wake-up enable register */ - --#define DEFAULT_TIMEOUT (5 * HZ) -+/* -+ * NOTE: By default the serial timeout is disabled as it causes lost characters -+ * over the serial ports. This means that the UART clocks will stay on until -+ * disabled via sysfs. This also causes that any deeper omap sleep states are -+ * blocked. -+ */ -+#define DEFAULT_TIMEOUT 0 - - struct omap_uart_state { - int num; -@@ -422,7 +428,8 @@ static void omap_uart_idle_init(struct omap_uart_state *uart) - uart->timeout = DEFAULT_TIMEOUT; - setup_timer(&uart->timer, omap_uart_idle_timer, - (unsigned long) uart); -- mod_timer(&uart->timer, jiffies + uart->timeout); -+ if (uart->timeout) -+ mod_timer(&uart->timer, jiffies + uart->timeout); - omap_uart_smart_idle_enable(uart, 0); - - if (cpu_is_omap34xx()) { diff --git a/a/content_digest b/N1/content_digest index a2e6e60..4cee49a 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,12 +1,10 @@ "ref\020100203022318.26347.34734.stgit@baageli.muru.com\0" "ref\020100203022618.26347.51428.stgit@baageli.muru.com\0" - "From\0Tony Lindgren <tony@atomide.com>\0" - "Subject\0Re: [PATCH 9/9] omap: Disable serial port autoidle by default\0" + "From\0tony@atomide.com (Tony Lindgren)\0" + "Subject\0[PATCH 9/9] omap: Disable serial port autoidle by default\0" "Date\0Tue, 2 Feb 2010 19:43:22 -0800\0" "To\0linux-arm-kernel@lists.infradead.org\0" - "Cc\0Kevin Hilman <khilman@deeprootsystems.com>" - " linux-omap@vger.kernel.org\0" - "\01:1\0" + "\00:1\0" "b\0" "* Tony Lindgren <tony@atomide.com> [100202 18:23]:\n" "> Currently the omap serial clocks are autoidled after 5 seconds.\n" @@ -32,59 +30,5 @@ "Regards,\n" "\n" Tony - "\01:2\0" - "fn\0fix-8250-timeout\0" - "b\0" - ">From ff7ce25ec59223bf987ad209c1eb183031811c07 Mon Sep 17 00:00:00 2001\n" - "From: Tony Lindgren <tony@atomide.com>\n" - "Date: Mon, 1 Feb 2010 12:34:31 -0800\n" - "Subject: [PATCH] omap: Disable serial port autoidle by default\n" - "\n" - "Currently the omap serial clocks are autoidled after 5 seconds.\n" - "However, this causes lost characters on the serial ports. As this\n" - "is considered non-standard behaviour for Linux, disable the timeout.\n" - "\n" - "Note that this will also cause blocking of any deeper omap sleep\n" - "states.\n" - "\n" - "To enable the autoidling of the serial ports, do something like\n" - "this for each serial port:\n" - "\n" - "# echo 5 > /sys/devices/platform/serial8250.0/sleep_timeout\n" - "# echo 5 > /sys/devices/platform/serial8250.1/sleep_timeout\n" - "...\n" - "\n" - "Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>\n" - "Signed-off-by: Tony Lindgren <tony@atomide.com>\n" - "\n" - "diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c\n" - "index 8c964be..e10a02d 100644\n" - "--- a/arch/arm/mach-omap2/serial.c\n" - "+++ b/arch/arm/mach-omap2/serial.c\n" - "@@ -36,7 +36,13 @@\n" - " #define UART_OMAP_NO_EMPTY_FIFO_READ_IP_REV\t0x52\n" - " #define UART_OMAP_WER\t\t0x17\t/* Wake-up enable register */\n" - " \n" - "-#define DEFAULT_TIMEOUT (5 * HZ)\n" - "+/*\n" - "+ * NOTE: By default the serial timeout is disabled as it causes lost characters\n" - "+ * over the serial ports. This means that the UART clocks will stay on until\n" - "+ * disabled via sysfs. This also causes that any deeper omap sleep states are\n" - "+ * blocked. \n" - "+ */\n" - "+#define DEFAULT_TIMEOUT 0\n" - " \n" - " struct omap_uart_state {\n" - " \tint num;\n" - "@@ -422,7 +428,8 @@ static void omap_uart_idle_init(struct omap_uart_state *uart)\n" - " \tuart->timeout = DEFAULT_TIMEOUT;\n" - " \tsetup_timer(&uart->timer, omap_uart_idle_timer,\n" - " \t\t (unsigned long) uart);\n" - "-\tmod_timer(&uart->timer, jiffies + uart->timeout);\n" - "+\tif (uart->timeout)\n" - "+\t\tmod_timer(&uart->timer, jiffies + uart->timeout);\n" - " \tomap_uart_smart_idle_enable(uart, 0);\n" - " \n" - " \tif (cpu_is_omap34xx()) {" -9ca64de366fe894f40b400d86090232c2affeed8fa3ee34cfffc9c15ce234176 +33ae6aec023c82e525c0530b1ff4415eb6216350322806a026bef05659a7b717
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.