From: Greg KH <gregkh@suse.de>
To: CB <c.bartlett.crb@googlemail.com>
Cc: wfp5p@virginia.edu, npalix@diku.dk, hjanssen@microsoft.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: hv: fix various coding style issues in RingBuffer.c
Date: Wed, 3 Feb 2010 07:49:33 -0800 [thread overview]
Message-ID: <20100203154933.GA29964@suse.de> (raw)
In-Reply-To: <1265211267.24459.11.camel@pcgfx805-laptop>
On Wed, Feb 03, 2010 at 03:34:27PM +0000, CB wrote:
> >From a545464b8c98ca1f2b35b6b701842bca16a6cccf Mon Sep 17 00:00:00 2001
> From: C. Bartlett <c-bartlett@hotmail.co.uk>
> Date: Wed, 3 Feb 2010 15:08:17 +0000
> Subject: [PATCH] Staging: hv: fix various coding style issues in RingBuffer.c
> This is a patch to the RingBuffer.c file that corrects various coding style warnings and errors found by checkpatch.pl
> Signed-off-by: Craig Bartlett <c-bartlett@hotmail.co.uk>
I'd really like to not take this patch, because this code should just be
replaced entirely with the in-kernel ringbuffer data structure instead
(as explained in the drivers/staging/hv/TODO file).
So could you work on that instead? That way we can just delete this
file entirely, which would be best.
thanks,
greg k-h
prev parent reply other threads:[~2010-02-03 15:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 15:34 [PATCH] Staging: hv: fix various coding style issues in RingBuffer.c CB
2010-02-03 15:49 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100203154933.GA29964@suse.de \
--to=gregkh@suse.de \
--cc=c.bartlett.crb@googlemail.com \
--cc=devel@driverdev.osuosl.org \
--cc=hjanssen@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=npalix@diku.dk \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.