Re: [linux-pm] [regression] "drm/i915: implement new pm ops" disables irq on aborted s2disk

["Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org>]

On Wednesday 03 February 2010, Alan Jenkins wrote:
> Hi
> 
> I found this regression on my EeePC 701 with modesetting enabled.  When 
> I hibernate using s2disk, I can abort the hibernation by pressing the 
> backspace key.  Doing so breaks X on 2.6.32-rc6 (but not 2.6.32).

Yeah.

To be honest, I knew that's going to happen, but didn't have the time to take
care of it.

The problem is that i915 does literally _nothing_ in its .thaw() callback,
although it should at least reverse whatever .freeze() did to the hardware
(and memory allocations and so on), so that the adapter is functional
after creating the image.

Fixing this requires some thought, though, because at the moment .freeze()
thinks it's .suspend(), which is not the case as this report clearly shows.
So, in fact i915_pci_suspend() has to be split into the .freeze() part and
the poweroff part cleanly and that's not  so simple (at least to me).

Hopefully I'll have some time to work on this during the weekend.

Rafael