From: Kees Cook <kees.cook@canonical.com>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serue@us.ibm.com>,
Casey Schaufler <casey@schaufler-ca.com>,
linux-security-module@vger.kernel.org,
Eric Paris <eparis@redhat.com>,
David Howells <dhowells@redhat.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Simon Kagstrom <simon.kagstrom@netinsight.net>,
David Woodhouse <David.Woodhouse@intel.com>,
Robin Getz <rgetz@analog.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Paul Moore <paul.moore@hp.com>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Stephen Smalley <sds@tycho.nsa.gov>,
Etienne Basset <etienne.basset@numericable.fr>,
"David P. Quigley" <dpquigl@tycho.nsa.gov>,
LKLM <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] syslog: distinguish between /proc/kmsg and syscalls
Date: Thu, 4 Feb 2010 00:09:23 -0800 [thread overview]
Message-ID: <20100204080923.GL19355@outflux.net> (raw)
In-Reply-To: <81b0412b1002032358j163d2e3fm2c0353ba3ec2842a@mail.gmail.com>
Hi Alex,
On Thu, Feb 04, 2010 at 08:58:43AM +0100, Alex Riesen wrote:
> > + /* /proc/kmsg can open be opened by CAP_SYS_ADMIN */
> > + if (type != 1 && from_file)
> > + return 0;
>
> "can open be opened"?
Erk, sorry. s/open //
James, do you want a patch for that?
-Kees
--
Kees Cook
Ubuntu Security Team
next prev parent reply other threads:[~2010-02-04 8:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 5:53 [PATCH] syslog: distinguish between /proc/kmsg and syscalls Kees Cook
2010-02-02 6:15 ` Casey Schaufler
2010-02-02 20:20 ` Kees Cook
2010-02-02 21:25 ` Serge E. Hallyn
2010-02-02 21:59 ` James Morris
2010-02-03 19:15 ` [PATCH 1/2] " Kees Cook
2010-02-03 20:44 ` Serge E. Hallyn
2010-02-03 19:23 ` [PATCH 2/2] syslog: use defined constants instead of raw numbers Kees Cook
2010-02-03 20:47 ` Serge E. Hallyn
2010-02-03 23:36 ` [PATCH v2 1/2] syslog: distinguish between /proc/kmsg and syscalls Kees Cook
2010-02-04 0:30 ` Serge E. Hallyn
2010-02-04 1:39 ` John Johansen
2010-02-04 3:52 ` James Morris
2010-02-04 7:58 ` Alex Riesen
2010-02-04 8:09 ` Kees Cook [this message]
2010-02-04 21:17 ` James Morris
2010-02-04 21:31 ` Serge E. Hallyn
2010-02-04 21:49 ` Eric Paris
2010-02-03 23:37 ` [PATCH v2 2/2] syslog: use defined constants instead of raw numbers Kees Cook
2010-02-04 0:35 ` Serge E. Hallyn
2010-02-04 1:38 ` John Johansen
2010-02-04 3:51 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100204080923.GL19355@outflux.net \
--to=kees.cook@canonical.com \
--cc=David.Woodhouse@intel.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=casey@schaufler-ca.com \
--cc=dhowells@redhat.com \
--cc=dpquigl@tycho.nsa.gov \
--cc=eparis@redhat.com \
--cc=etienne.basset@numericable.fr \
--cc=gregkh@suse.de \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paul.moore@hp.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=raa.lkml@gmail.com \
--cc=rgetz@analog.com \
--cc=sds@tycho.nsa.gov \
--cc=serue@us.ibm.com \
--cc=simon.kagstrom@netinsight.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.