From: Hal Rosenstock <hnrose-Wuw85uim5zDR7s880joybQ@public.gmane.org>
To: sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH] opensm/osm_mcast_mgr.c: Cosmetic changes
Date: Thu, 4 Feb 2010 09:27:28 -0500 [thread overview]
Message-ID: <20100204142728.GA14122@comcast.net> (raw)
Fix some commentary typos
Remove osm_ from static routine names
Signed-off-by: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
diff --git a/opensm/opensm/osm_mcast_mgr.c b/opensm/opensm/osm_mcast_mgr.c
index 19d0593..37ff120 100644
--- a/opensm/opensm/osm_mcast_mgr.c
+++ b/opensm/opensm/osm_mcast_mgr.c
@@ -195,7 +195,7 @@ static void mcast_mgr_build_switch_map(osm_sm_t * sm,
cl_qmap_insert(p_mcast_member_sw_tbl, port_guid, &remote_sw->mgrp_item);
/* New element in the table */
if (p_port->p_node->sw)
- /* the switch is MC memeber */
+ /* the switch is MC member */
remote_sw->is_mc_member = 1;
else
/* for others - update MC count */
@@ -229,8 +229,8 @@ static void mcast_mgr_destroy_switch_map(osm_sm_t * sm,
of the group HCAs
**********************************************************************/
#ifdef OSM_VENDOR_INTF_ANAFA
-static float osm_mcast_mgr_compute_avg_hops(osm_sm_t * sm, cl_qmap_t * m,
- const osm_switch_t * this_sw)
+static float mcast_mgr_compute_avg_hops(osm_sm_t * sm, cl_qmap_t * m,
+ const osm_switch_t * this_sw)
{
float avg_hops = 0;
uint32_t hops = 0;
@@ -254,7 +254,7 @@ static float osm_mcast_mgr_compute_avg_hops(osm_sm_t * sm, cl_qmap_t * m,
num_ports += sw->num_of_mcm + sw->is_mc_member;
}
- /* We should be here if there aren't any ports in the group. */
+ /* We shouldn't be here if there aren't any ports in the group. */
CL_ASSERT(num_ports);
avg_hops = (float)(hops / num_ports);
@@ -263,8 +263,8 @@ static float osm_mcast_mgr_compute_avg_hops(osm_sm_t * sm, cl_qmap_t * m,
return avg_hops;
}
#else
-static float osm_mcast_mgr_compute_max_hops(osm_sm_t * sm, cl_qmap_t * m,
- const osm_switch_t * this_sw)
+static float mcast_mgr_compute_max_hops(osm_sm_t * sm, cl_qmap_t * m,
+ const osm_switch_t * this_sw)
{
uint32_t max_hops = 0, hops;
uint16_t lid;
@@ -322,9 +322,9 @@ static osm_switch_t *mcast_mgr_find_optimal_switch(osm_sm_t * sm,
continue;
#ifdef OSM_VENDOR_INTF_ANAFA
- hops = osm_mcast_mgr_compute_avg_hops(sm, &mgrp_sw_map, p_sw);
+ hops = mcast_mgr_compute_avg_hops(sm, &mgrp_sw_map, p_sw);
#else
- hops = osm_mcast_mgr_compute_max_hops(sm, &mgrp_sw_map, p_sw);
+ hops = mcast_mgr_compute_max_hops(sm, &mgrp_sw_map, p_sw);
#endif
OSM_LOG(sm->p_log, OSM_LOG_DEBUG,
@@ -352,7 +352,7 @@ static osm_switch_t *mcast_mgr_find_optimal_switch(osm_sm_t * sm,
}
/**********************************************************************
- This function returns the existing or optimal root swtich for the tree.
+ This function returns the existing or optimal root switch for the tree.
**********************************************************************/
static osm_switch_t *mcast_mgr_find_root_switch(osm_sm_t * sm, cl_qlist_t *list)
{
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2010-02-04 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 14:27 Hal Rosenstock [this message]
[not found] ` <20100204142728.GA14122-Wuw85uim5zDR7s880joybQ@public.gmane.org>
2010-02-04 20:37 ` [PATCH] opensm/osm_mcast_mgr.c: Cosmetic changes Sasha Khapyorsky
-- strict thread matches above, loose matches on Subject: below --
2009-10-14 20:01 Hal Rosenstock
[not found] ` <20091014200124.GA18516-Wuw85uim5zDR7s880joybQ@public.gmane.org>
2009-10-14 20:37 ` Sasha Khapyorsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100204142728.GA14122@comcast.net \
--to=hnrose-wuw85uim5zdr7s880joybq@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.