From: Paul Mundt <lethal@linux-sh.org>
To: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Li Zefan <lizf@cn.fujitsu.com>, Paul Menage <menage@google.com>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH -mmotm 7/8] memcg: move charges of anonymous swap
Date: Fri, 5 Feb 2010 10:16:02 +0900 [thread overview]
Message-ID: <20100205011602.GA8416@linux-sh.org> (raw)
In-Reply-To: <20100205093806.5699d406.nishimura@mxp.nes.nec.co.jp>
On Fri, Feb 05, 2010 at 09:38:06AM +0900, Daisuke Nishimura wrote:
> On Thu, 4 Feb 2010 16:44:41 +0900, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> > On Thu, 4 Feb 2010 16:18:40 +0900
> > Paul Mundt <lethal@linux-sh.org> wrote:
> > > CONFIG_SWAP itself is configurable even with CONFIG_MMU=y, so having
> > > stubbed out helpers for the CONFIG_SWAP=n case would give the compiler a
> > > chance to optimize things away in those cases, too. Embedded systems
> > > especially will often have MMU=y and BLOCK=n, resulting in SWAP being
> > > unset but swap cache encodings still defined.
> > >
> > > How about just changing the is_swap_pte() definition to depend on SWAP
> > > instead?
> > >
> > I think the new feature as "move task charge" itself depends on CONFIG_MMU
> > because it walks a process's page table.
> >
> > Then, how about this ? (sorry, I can't test this in valid way..)
> >
> I agree to this direction of making "move charge" depend on CONFIG_MMU,
> although I can't test !CONFIG_MMU case either.
>
I'll try to give it a test on nommu today and see how it goes.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-02-05 1:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-21 5:31 [PATCH -mmotm 0/8] memcg: move charge at task migration (21/Dec) Daisuke Nishimura
2009-12-21 5:32 ` [PATCH -mmotm 1/8] cgroup: introduce cancel_attach() Daisuke Nishimura
2009-12-21 5:32 ` [PATCH -mmotm 2/8] cgroup: introduce coalesce css_get() and css_put() Daisuke Nishimura
2009-12-21 5:33 ` [PATCH -mmotm 3/8] memcg: add interface to move charge at task migration Daisuke Nishimura
2009-12-21 7:00 ` KAMEZAWA Hiroyuki
2009-12-21 5:35 ` [PATCH -mmotm 4/8] memcg: move charges of anonymous page Daisuke Nishimura
2009-12-21 7:01 ` KAMEZAWA Hiroyuki
2009-12-23 0:26 ` Andrew Morton
2009-12-21 5:36 ` [PATCH -mmotm 5/8] memcg: improve performance in moving charge Daisuke Nishimura
2009-12-21 7:02 ` KAMEZAWA Hiroyuki
2009-12-21 5:37 ` [PATCH -mmotm 6/8] memcg: avoid oom during " Daisuke Nishimura
2009-12-21 7:03 ` KAMEZAWA Hiroyuki
2009-12-21 5:38 ` [PATCH -mmotm 7/8] memcg: move charges of anonymous swap Daisuke Nishimura
2009-12-21 7:04 ` KAMEZAWA Hiroyuki
2010-02-04 3:31 ` Andrew Morton
2010-02-04 5:09 ` Daisuke Nishimura
2010-02-04 5:27 ` KAMEZAWA Hiroyuki
2010-02-04 7:18 ` Paul Mundt
2010-02-04 7:44 ` KAMEZAWA Hiroyuki
2010-02-04 15:32 ` Balbir Singh
2010-02-05 0:38 ` Daisuke Nishimura
2010-02-05 0:54 ` KAMEZAWA Hiroyuki
2010-02-05 1:16 ` Paul Mundt [this message]
2010-03-09 23:13 ` Andrew Morton
2010-03-10 2:50 ` Daisuke Nishimura
2009-12-21 5:40 ` [PATCH -mmotm 8/8] memcg: improve performance in moving swap charge Daisuke Nishimura
2009-12-21 7:05 ` KAMEZAWA Hiroyuki
-- strict thread matches above, loose matches on Subject: below --
2009-12-14 6:17 [PATCH -mmotm 0/8] memcg: move charge at task migration (14/Dec) Daisuke Nishimura
2009-12-14 6:25 ` [PATCH -mmotm 7/8] memcg: move charges of anonymous swap Daisuke Nishimura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100205011602.GA8416@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.