All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: linux-mmc@vger.kernel.org, Philip Langdale <philipl@overt.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Jorg Schummer <ext-jorg.2.schummer@nokia.com>,
	linux-pm <linux-pm@lists.linux-foundation.org>
Subject: Re: [PATCH] MMC: fix hang if card was removed during suspend and unsafe resume was enabled
Date: Fri, 5 Feb 2010 06:39:11 -0800	[thread overview]
Message-ID: <20100205063911.05eca1c6.akpm@linux-foundation.org> (raw)
In-Reply-To: <1265379560.14522.2.camel@maxim-laptop>

On Fri, 05 Feb 2010 16:19:20 +0200 Maxim Levitsky <maximlevitsky@gmail.com> wrote:

> > 
> > There is no del_disk in the kernel.  Let's be more specific (and
> > accurate!) about the hang.  I assume it's
> > mmc_remove_card->device_del->kobject_uevent?
> Sorry!
> I was referring to del_gendisk. 
> 
> <4>[15241.042047]  [<ffffffff8106620a>] ? prepare_to_wait+0x2a/0x90
> <4>[15241.042159]  [<ffffffff810790bd>] ? trace_hardirqs_on+0xd/0x10
> <4>[15241.042271]  [<ffffffff8140db12>] ? _raw_spin_unlock_irqrestore+0x42/0x80
> <4>[15241.042386]  [<ffffffff8112a390>] ? bdi_sched_wait+0x0/0x20
> <4>[15241.042496]  [<ffffffff8112a39e>] bdi_sched_wait+0xe/0x20
> <4>[15241.042606]  [<ffffffff8140af6f>] __wait_on_bit+0x5f/0x90
> <4>[15241.042714]  [<ffffffff8112a390>] ? bdi_sched_wait+0x0/0x20
> <4>[15241.042824]  [<ffffffff8140b018>] out_of_line_wait_on_bit+0x78/0x90
> <4>[15241.042935]  [<ffffffff81065fd0>] ? wake_bit_function+0x0/0x40
> <4>[15241.043045]  [<ffffffff8112a2d3>] ? bdi_queue_work+0xa3/0xe0
> <4>[15241.043155]  [<ffffffff8112a37f>] bdi_sync_writeback+0x6f/0x80
> <4>[15241.043265]  [<ffffffff8112a3d2>] sync_inodes_sb+0x22/0x120
> <4>[15241.043375]  [<ffffffff8112f1d2>] __sync_filesystem+0x82/0x90
> <4>[15241.043485]  [<ffffffff8112f3db>] sync_filesystem+0x4b/0x70
> <4>[15241.043594]  [<ffffffff811391de>] fsync_bdev+0x2e/0x60
> <4>[15241.043704]  [<ffffffff812226be>] invalidate_partition+0x2e/0x50
> <4>[15241.043816]  [<ffffffff8116b92f>] del_gendisk+0x3f/0x140
> <4>[15241.043926]  [<ffffffffa00c0233>] mmc_blk_remove+0x33/0x60 [mmc_block]
> <4>[15241.044043]  [<ffffffff81338977>] mmc_bus_remove+0x17/0x20
> <4>[15241.044152]  [<ffffffff812ce746>] __device_release_driver+0x66/0xc0
> <4>[15241.044264]  [<ffffffff812ce89d>] device_release_driver+0x2d/0x40
> <4>[15241.044375]  [<ffffffff812cd9b5>] bus_remove_device+0xb5/0x120
> <4>[15241.044486]  [<ffffffff812cb46f>] device_del+0x12f/0x1a0
> <4>[15241.044593]  [<ffffffff81338a5b>] mmc_remove_card+0x5b/0x90
> <4>[15241.044702]  [<ffffffff8133ac27>] mmc_sd_remove+0x27/0x50
> <4>[15241.044811]  [<ffffffff81337d8c>] mmc_resume_host+0x10c/0x140
> <4>[15241.044929]  [<ffffffffa00850e9>] sdhci_resume_host+0x69/0xa0 [sdhci]
> <4>[15241.045044]  [<ffffffffa0bdc39e>] sdhci_pci_resume+0x8e/0xb0 [sdhci_pci]

So what's the hang?  del_gendisk is doing IO?  I'd assumed that it was
because it was calling kobject_uevent, but userspace is frozen.

Why is it this hard :(

  reply	other threads:[~2010-02-05 14:39 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-03 17:47 Hand on resume if sd/mmc card was removed while system was suspended/hibernated Maxim Levitsky
2010-02-04 23:18 ` [PATCH] MMC: fix hang if card was removed during suspend and unsafe resume was enabled Maxim Levitsky
2010-02-05  0:09   ` Andrew Morton
2010-02-05  8:31     ` Maxim Levitsky
2010-02-05  8:31       ` Maxim Levitsky
2010-02-05 14:13       ` Andrew Morton
2010-02-05 14:13       ` Andrew Morton
2010-02-05 14:19         ` Maxim Levitsky
2010-02-05 14:39           ` Andrew Morton [this message]
2010-02-05 15:52             ` Maxim Levitsky
2010-02-05 15:52             ` Maxim Levitsky
2010-02-05 16:19               ` Madhusudhan
2010-02-05 16:19                 ` Madhusudhan
2010-02-05 16:32                 ` Maxim Levitsky
2010-02-05 16:32                   ` Maxim Levitsky
2010-02-05 16:19               ` Madhusudhan
2010-02-05 18:26               ` Andrew Morton
2010-02-05 19:58                 ` Maxim Levitsky
2010-02-05 19:58                 ` Maxim Levitsky
2010-02-05 18:26               ` Andrew Morton
2010-02-05 14:39           ` Andrew Morton
2010-02-05 14:19         ` Maxim Levitsky
2010-02-05 10:17     ` Adrian Hunter
2010-02-05 13:42       ` Maxim Levitsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100205063911.05eca1c6.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=ext-jorg.2.schummer@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=maximlevitsky@gmail.com \
    --cc=philipl@overt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.