From: Jens Axboe <jens.axboe@oracle.com>
To: "Stephen M. Cameron" <scameron@beardog.cce.hp.com>
Cc: akpm@linux-foundation.org, stable@kernel.org,
mikem@beardog.cce.hp.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cciss: Make cciss_seq_show handle holes in the h->drv[] array.
Date: Fri, 5 Feb 2010 13:14:43 +0100 [thread overview]
Message-ID: <20100205121443.GF1025@kernel.dk> (raw)
In-Reply-To: <20100204224929.12371.65766.stgit@beardog.cce.hp.com>
On Thu, Feb 04 2010, Stephen M. Cameron wrote:
> From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
>
> cciss: Make cciss_seq_show handle holes in the h->drv[] array.
> It is possible (and expected) for there to be holes in the h->drv[]
> array, that is, some elements may be NULL pointers. cciss_seq_show
> needs to be made aware of this possibility to avoid an Oops.
>
> To reproduce the Oops which this fixes:
>
> 1) Create two "arrays" in the Array Configuratino Utility and
> several logical drives on each array.
> 2) cat /proc/driver/cciss/cciss* in an infinite loop
> 3) delete some of the logical drives in the first "array."
>
> Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Thanks Stephen, applied for 2.6.33. BTW, you want to put that stable cc
into the patch itself as well, then it'll get picked up automatically
when Linus merges it.
--
Jens Axboe
prev parent reply other threads:[~2010-02-05 12:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 22:52 [PATCH] cciss: Make cciss_seq_show handle holes in the h->drv[] array Stephen M. Cameron
2010-02-05 12:14 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100205121443.GF1025@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikem@beardog.cce.hp.com \
--cc=scameron@beardog.cce.hp.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.