From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ronny.Hegewald@online.de
Cc: xen-devel@lists.xensource.com
Subject: Re: pvops dom0: no sound after boot; possibly causedby swiotlb
Date: Fri, 5 Feb 2010 11:24:29 -0500 [thread overview]
Message-ID: <20100205162429.GA7887@phenom.dumpdata.com> (raw)
In-Reply-To: <17472149.3960821265244940127.JavaMail.servlet@kundenserver>
> No, your first statement was correct. It would always return the same mask for 32-bit and 64-bit, because of the 32-bitness of the return-variable 'dma_mask'.
>
> So the following patch maybe would be more appropriate?
I think it isn't neccessary. The 'dmal_alloc_coherent_mask' returns an
unsigned long. On 32-bit 'unsigned long' is a 4-byte value, and
on 64-bit that is 8-byte value. So I think your previous patch:
http://lists.xensource.com/archives/html/xen-devel/2010-02/msg00038.html
is correct as when it is compiled under 64-bit it would return a 64-bit
value and when compiled under 32-bit, it would return a 32-bit value.
This would mimick the behavior of upstream logic.
next prev parent reply other threads:[~2010-02-05 16:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 0:55 pvops dom0: no sound after boot; possibly causedby swiotlb Ronny.Hegewald
2010-02-05 16:24 ` Konrad Rzeszutek Wilk [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-02-01 20:54 Ronny.Hegewald
2010-02-01 21:52 ` Konrad Rzeszutek Wilk
2010-01-26 19:27 Ronny.Hegewald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100205162429.GA7887@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Ronny.Hegewald@online.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.