From: Stephen Hemminger <shemminger@vyatta.com>
To: Mike McCormack <mikem@ring3k.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] sky2: Allocate initial skbs in sky2_alloc_buffers
Date: Fri, 5 Feb 2010 18:10:45 -0800 [thread overview]
Message-ID: <20100205181045.42908795@nehalam> (raw)
In-Reply-To: <4B6CC473.4090008@ring3k.org>
On Sat, 06 Feb 2010 10:22:59 +0900
Mike McCormack <mikem@ring3k.org> wrote:
> Allocating everything in one place means there's a single point
> of failure in sky2_up, and sky2_rx_start can no longer fail.
If ring is never allocated, how then it must fail in up.
Plus if the initial ring allocation is partial it should fail.
--
next prev parent reply other threads:[~2010-02-06 2:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-06 1:22 [PATCH 2/2] sky2: Allocate initial skbs in sky2_alloc_buffers Mike McCormack
2010-02-06 2:10 ` Stephen Hemminger [this message]
2010-02-06 6:12 ` Stephen Hemminger
2010-02-07 9:56 ` Mike McCormack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100205181045.42908795@nehalam \
--to=shemminger@vyatta.com \
--cc=mikem@ring3k.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.