From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Ndsyc-00011o-D2
	for qemu-devel@nongnu.org; Sat, 06 Feb 2010 17:18:06 -0500
Received: from [199.232.76.173] (port=49420 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ndsyc-00011g-1Q
	for qemu-devel@nongnu.org; Sat, 06 Feb 2010 17:18:06 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <aurelien@aurel32.net>) id 1Ndsya-000668-MA
	for qemu-devel@nongnu.org; Sat, 06 Feb 2010 17:18:05 -0500
Received: from hall.aurel32.net ([88.191.82.174]:44185)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <aurelien@aurel32.net>)
	id 1Ndsya-000662-5B
	for qemu-devel@nongnu.org; Sat, 06 Feb 2010 17:18:04 -0500
Date: Sat, 6 Feb 2010 23:18:01 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 01/14] arm host: Fix compiler warning
Message-ID: <20100206221801.GE15349@volta.aurel32.net>
References: <1264013005-16965-1-git-send-email-weil@mail.berlios.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1264013005-16965-1-git-send-email-weil@mail.berlios.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On Wed, Jan 20, 2010 at 07:43:25PM +0100, Stefan Weil wrote:
> Compilation for arm (native or cross) results in this
> warning:
> 
> fpu/softfloat-native.c: In function ‘float64_round_to_int’:
> fpu/softfloat-native.c:387: error: control reaches end of non-void function
> 
> float64_round_to_int uses special assembler code for arm
> and has no explicit return value.
> 
> As there is no obvious reason why arm should need special
> code, all fpu related conditionals were removed.
> The remaining code is standard (C99) and compiles for arm,
> too.

The reason for this special code is that ARM old ABI does not have the
FE_* constants defined. Only EABI is supported since the switch to TCG,
so this is not a problem removing that code.

Patch applied.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net