All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
	gregkh@suse.de, taviso@google.com, viro@ZenIV.linux.org.uk,
	linux-kernel@vger.kernel.org, ebiederm@xmission.com,
	alan@lxorguk.ukuu.org.uk, jdike@addtoit.com, jln@google.com,
	mpm@selenic.com
Subject: Re: [2.6.33-rc5] tty: possible irq lock inversion dependency in tty_fasync
Date: Sun, 7 Feb 2010 14:46:56 +0800	[thread overview]
Message-ID: <20100207064643.GA15533@hack> (raw)
In-Reply-To: <alpine.LFD.2.00.1002062226000.3829@localhost.localdomain>

On Sat, Feb 06, 2010 at 10:31:30PM -0800, Linus Torvalds wrote:
>
>
>On Sun, 7 Feb 2010, Tetsuo Handa wrote:
>> 
>> Below problem (which was introduced between 2.6.33-rc4 and 2.6.33-rc5) is
>> not yet fixed as of 2.6.33-rc7.
>> "git bisect start v2.6.33-rc5 v2.6.33-rc4" reported that
>> 703625118069f9f8960d356676662d3db5a9d116 tty: fix race in tty_fasync
>> is first bad commit.
>
>Yeah. I think we need to just revert that commit.
>
>Or maybe we could just do the following, rather than revert it outright: 
>just get a ref to the 'struct pid' while holding the spinlock, and then 
>releasing it after doing the __f_setown() call.

We already fixed this, a better fix:

http://lkml.org/lkml/2010/1/26/338

I sent a same fix with Greg's.

Thanks.

  parent reply	other threads:[~2010-02-07  6:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-07  5:52 [2.6.33-rc5] tty: possible irq lock inversion dependency in tty_fasync Tetsuo Handa
2010-02-07  6:31 ` Linus Torvalds
2010-02-07  6:46   ` Linus Torvalds
2010-02-07  7:27     ` Greg KH
2010-02-07  8:12       ` [2.6.33-rc5] tty: possible irq lock inversion dependency intty_fasync Tetsuo Handa
2010-02-07  6:46   ` Américo Wang [this message]
2010-02-07  6:59     ` [2.6.33-rc5] tty: possible irq lock inversion dependency in tty_fasync Linus Torvalds
2010-02-07 16:06       ` Américo Wang
2010-02-07  7:00     ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100207064643.GA15533@hack \
    --to=xiyou.wangcong@gmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=ebiederm@xmission.com \
    --cc=gregkh@suse.de \
    --cc=jdike@addtoit.com \
    --cc=jln@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=taviso@google.com \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.