From: Al Viro <viro@ZenIV.linux.org.uk>
To: James Morris <jmorris@namei.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Xiaotian Feng <dfeng@redhat.com>, Eric Paris <eparis@redhat.com>,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, serue@linux.vnet.ibm.com,
Eugene Teo <eugene@redhat.com>,
Mimi Zohar <zohar@linux.vnet.ibm.com>
Subject: Re: [GIT][IMA] fix null pointer deref
Date: Sun, 7 Feb 2010 07:56:58 +0000 [thread overview]
Message-ID: <20100207075658.GF30031@ZenIV.linux.org.uk> (raw)
In-Reply-To: <alpine.LRH.2.00.1002071832080.21000@tundra.namei.org>
On Sun, Feb 07, 2010 at 06:34:51PM +1100, James Morris wrote:
> Linus,
>
> Please pull this bugfix. I've verified that it fixes the null pointer
> deref.
NAK. In that form it's simply wrong; we should never get there with
NULL file->f_dentry->d_inode at all. This is papering over the real
bug; I'll post a saner fix shortly.
The real problem is BS hiding of ima_file_free() inside a hook, with
condition that kinda-sorta happens to avoid bogus call most of the
time.
ima_path_check() side is also of BUG_ON() variety (and isn't triggered).
next prev parent reply other threads:[~2010-02-07 7:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 10:14 [PATCH] ima: avoid null pointer deref in ima_main.c Xiaotian Feng
2010-02-05 13:48 ` Mimi Zohar
2010-02-07 6:30 ` James Morris
2010-02-07 7:34 ` [GIT][IMA] fix null pointer deref James Morris
2010-02-07 7:56 ` Al Viro [this message]
2010-02-08 3:42 ` Mimi Zohar
2010-02-08 5:33 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100207075658.GF30031@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dfeng@redhat.com \
--cc=eparis@redhat.com \
--cc=eugene@redhat.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serue@linux.vnet.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.