From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcin Slusarz Subject: Re: [PATCH] drm/nouveau: don't hold spin lock while calling kzalloc with GFP_KERNEL Date: Sun, 7 Feb 2010 10:54:04 +0100 Message-ID: <20100207095404.GA2870@joi.lan> References: <1265505080-7099-1-git-send-email-madman2003@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1265505080-7099-1-git-send-email-madman2003-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org To: Maarten Maathuis Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: nouveau.vger.kernel.org On Sun, Feb 07, 2010 at 02:11:20AM +0100, Maarten Maathuis wrote: > - 'joi' on irc pointed out that this triggers a BUG_ON, because kzalloc could > sleep. > - The irq handler should restore the value NV03_PFIFO_CACHES, but still it's > better if this stuff doesn't happen in the middle of fifo create context. I see > no reason in spin locking pgraph create context, it isn't activated at that > stage. > - Move and rename the lock after some discussion with 'joi', even better naming > suggestions are appreciated. > > Signed-off-by: Maarten Maathuis (joi==/me) Tested-by: Marcin Slusarz