From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>,
Johan Herland <johan@herland.net>,
git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: notes TODOs
Date: Sun, 7 Feb 2010 20:05:04 +0100 [thread overview]
Message-ID: <201002072005.05832.jnareb@gmail.com> (raw)
In-Reply-To: <7vr5oy2qh3.fsf@alter.siamese.dyndns.org>
On Sat, 6 Feb 2010, Junio C Hamano wrote:
> Jakub Narebski <jnareb@gmail.com> writes:
>
> > 'git notes' move [-f] <oldobject> <newobject>
>
> I suspect "copy" to keep the old one than "move" would be a lot more
> sensible, especially when you are talking about people (like me) who amend
> often. They cannot get it right in their first try by definition ;-), and
> their very original edition is sometimes easier to start from than their
> second edition, when they are trying to come up with the final edition of
> the commit. Using "move" to lose the notes from the old object will make
> it harder to go back to the original and start amending from there.
True. It would be better then to have "git notes copy ...", and perhaps
even a configuration option to have --amend copy notes to new version
automatically.
You can always get note before move with
GIT_NOTES_REF=refs/notes/commit^ <git command>
(assuming that you use default notes ref). But that would work for
"git show", but not for "git log --walk-reflogs".
P.S. I have tried to use 'git notes edit v1.6.6.1', and while it annotates
a tag object, the message in editor make it look like you are annotating
the commit it points to.
--
Jakub Narebski
Poland
prev parent reply other threads:[~2010-02-07 19:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 12:44 notes TODOs (was: Re: [PATCH 1/4] gitweb: notes feature) Giuseppe Bilotta
2010-02-05 14:46 ` Johan Herland
2010-02-05 15:27 ` Jakub Narebski
2010-02-05 16:58 ` Giuseppe Bilotta
2010-02-06 11:30 ` Jakub Narebski
2010-02-06 18:01 ` notes TODOs Junio C Hamano
2010-02-07 19:05 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002072005.05832.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=giuseppe.bilotta@gmail.com \
--cc=johan@herland.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.