From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh-sci: remove SCIF code in sci_rxd_in()
Date: Mon, 08 Feb 2010 02:50:28 +0000 [thread overview]
Message-ID: <20100208025028.GD6839@linux-sh.org> (raw)
In-Reply-To: <20100205104100.16820.16353.sendpatchset@rxone.opensource.se>
On Fri, Feb 05, 2010 at 07:41:00PM +0900, Magnus Damm wrote:
> --- 0001/drivers/serial/sh-sci.h
> +++ work/drivers/serial/sh-sci.h 2010-02-05 16:02:19.000000000 +0900
> @@ -518,34 +456,6 @@ static inline int sci_rxd_in(struct uart
> {
> if (port->mapbase = 0xfffffe80)
> return __raw_readb(SCPDR)&0x01 ? 1 : 0; /* SCI */
> - if (port->mapbase = 0xa4000150)
> - return __raw_readb(SCPDR)&0x10 ? 1 : 0; /* SCIF */
> - if (port->mapbase = 0xa4000140)
> - return __raw_readb(SCPDR)&0x04 ? 1 : 0; /* IRDA */
> - return 1;
> -}
I've applied the parts that clean up sci_rxd_in(), but dropped all of the
register definition deletions. Those definitions are used throughout the
driver in random locations by different subtypes, as well as places like
sci_init_pins().
There's a lot of work that needs to be done before we can safely kill
them off.
prev parent reply other threads:[~2010-02-08 2:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 10:41 [PATCH] sh-sci: remove SCIF code in sci_rxd_in() Magnus Damm
2010-02-08 2:50 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100208025028.GD6839@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.