From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Subject: Re: [PATCH] Modification of lexer and parser, improving dtc portability. Date: Mon, 8 Feb 2010 19:13:33 +1100 Message-ID: <20100208081333.GA19789@yookeroo> References: <1264782711-52086-1-git-send-email-zbr@semihalf.com> <20100201044601.GA8095@yookeroo> <4B6A9683.300@semihalf.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <4B6A9683.300-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Lukasz Wojcik Cc: Devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, Feb 04, 2010 at 10:42:27AM +0100, Lukasz Wojcik wrote: > On 01.02.2010 05:46, David Gibson wrote: > >On Fri, Jan 29, 2010 at 05:31:51PM +0100, Lukasz Wojcik wrote: > >>This mod allows successful build of dtc using both bison/flex and > >>yacc/lex. > >Hrm. This will enable dtc to build with both bison and yacc, however, > >it will sacrifice the (much) more useful error messages that > >%locations gives us on bison. So I'm not very happy to do this > >unconditionally. > Would you be so kind, and possibly point me out where exactly the > differences between error messages before and after applying this > patch lies ? I did some > testing around dtc being compiled using: Ah, sorry, I was mistaken. I'd forgotten that we were using our own overridden version of yyerror() which will generate errors including location information, even with %locations. I withdraw my objections to the patch. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson