From: Jakub Narebski <jnareb@gmail.com>
To: "J.H." <warthog19@eaglescrag.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Die if there are parsing errors in config file
Date: Mon, 8 Feb 2010 09:48:26 +0100 [thread overview]
Message-ID: <201002080948.27094.jnareb@gmail.com> (raw)
In-Reply-To: <4B6E9BBB.4000904@eaglescrag.net>
On Sun, 7 Feb 2010, J.H. wrote:
> I'd sign-off that, I've probably run into it a couple of times myself.
>
> - John 'Warthog9' Hawley
I think you meant ACK, not sign-off...
> On 02/07/2010 01:40 AM, Jakub Narebski wrote:
> > Otherwise the errors can propagate, and show in damnest places, and
> > you would spend your time chasing ghosts instead of debugging real
> > problem (yes, it is from personal experience).
> >
> > This follows (parts of) advice in `perldoc -f do` documentation.
> >
> > Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> > ---
> > This is fallout from my work on [split] "Gitweb output caching" series.
> > Before I used `die $@ if $@;' in t/t9503/test_cache_interface.pl, tests
> > failed for no discernable reason...
> >
> > So I think the same should be done for the gitweb config file.
[...]
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2010-02-08 8:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-07 9:40 [PATCH] gitweb: Die if there are parsing errors in config file Jakub Narebski
2010-02-07 10:53 ` J.H.
2010-02-08 8:48 ` Jakub Narebski [this message]
2010-02-13 2:46 ` Jakub Narebski
2010-02-14 21:17 ` Junio C Hamano
2010-02-14 21:46 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002080948.27094.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=warthog19@eaglescrag.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.