From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pete Zaitcev <zaitcev@redhat.com>
Subject: Re: [Patch 1/1] CLD: Introduce the "New CLD" API
Date: Mon, 8 Feb 2010 19:17:01 -0700
Message-ID: <20100208191701.6e15b452@redhat.com>
References: <20100207121550.7ee94ff6@redhat.com>
	<4B700478.3020305@garzik.org>
	<20100208184649.51374774@redhat.com>
	<4B70C319.6040005@garzik.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <hail-devel-owner@vger.kernel.org>
In-Reply-To: <4B70C319.6040005@garzik.org>
Sender: hail-devel-owner@vger.kernel.org
List-ID: <hail-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
To: Jeff Garzik <jeff@garzik.org>
Cc: Project Hail List <hail-devel@vger.kernel.org>

On Mon, 08 Feb 2010 21:06:17 -0500
Jeff Garzik <jeff@garzik.org> wrote:

> > -	if (cldc_getaddr(&host_list, hostb, NULL))
> > +	if (cldc_getaddr(&host_list, hostb, &ncld_log))
> >   		return 1001;

> Logging pointer should be supplied by the caller...  that is the larger 
> bug.  Needing a no-op log function is just an indication of that.

I did it before, but then every client, without exception, needed
to include <stdarg.h> and provide the log. And what for? This is
STUPID and proof is in the pudding: your getsrvinfo does not do
anything of the sort. Might as well replace cldc_getadd with getsrvinfo
and then everyone becomes happy.

-- Pete