All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frans Pop <elendil@planet.nl>
To: ccube <friends@ccube.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] option.c added DELL wireless HSDPA 5540 Modem
Date: Mon, 8 Feb 2010 19:51:49 +0100	[thread overview]
Message-ID: <201002081951.50321.elendil@planet.nl> (raw)
In-Reply-To: <4B705244.2010606@ccube.de>

Hi,

ccube wrote:
> i really dont know if everything is correct.
> This is my first submit into this mailing list.
> I added support for my HSDPA UMTS-card.
> Perhaps you can check! ;)

There are two main problems with your patch.

1) The lines in the patch have been line-wrapped by your mail client.
   This means the patch will not apply.
2) The patch is not signed off, which prevents inclusion.

Please see Documentation/SubmittingPatches and the other documents 
referenced there.

You should also try to Cc the most relevant maintainers of the code you're 
changing. In this case the linux-usb list (also on vger.kernel.org).

Cheers,
FJP

      reply	other threads:[~2010-02-08 18:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-08 18:04 [PATCH] option.c added DELL wireless HSDPA 5540 Modem ccube
2010-02-08 18:51 ` Frans Pop [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201002081951.50321.elendil@planet.nl \
    --to=elendil@planet.nl \
    --cc=friends@ccube.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.